New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom0 label discrepancy #3102

Open
rootkovska opened this Issue Sep 20, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@rootkovska
Member

rootkovska commented Sep 20, 2017

qvm-prefs reports dom0 label as black. Our Windows Manager plugin displays the gray/silver label.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 20, 2017

Member

Window manager do not know what label is set by qvm-prefs, because dom0 windows are not created by gui-daemon (so do not have _QUBES_* X properties). I think we should forbid changing dom0 label and set it the same in both qvm-prefs and window managers. What color do you prefer?

Member

marmarek commented Sep 20, 2017

Window manager do not know what label is set by qvm-prefs, because dom0 windows are not created by gui-daemon (so do not have _QUBES_* X properties). I think we should forbid changing dom0 label and set it the same in both qvm-prefs and window managers. What color do you prefer?

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Sep 21, 2017

Member

How about some special kind of color, say: "adminvm"?

Member

rootkovska commented Sep 21, 2017

How about some special kind of color, say: "adminvm"?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 21, 2017

Member

Why? Would that be a color outside of any color palette? ;)
Alternatively, we may drop 'label' property from dom0 at all.

Member

marmarek commented Sep 21, 2017

Why? Would that be a color outside of any color palette? ;)
Alternatively, we may drop 'label' property from dom0 at all.

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Sep 22, 2017

Member

Note the property is called "label", not "color" :) So, yeah, the idea is to have something special reserved for this. Also, in the future we will likely introduce another label perhaps: "guidom"?

Member

rootkovska commented Sep 22, 2017

Note the property is called "label", not "color" :) So, yeah, the idea is to have something special reserved for this. Also, in the future we will likely introduce another label perhaps: "guidom"?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 22, 2017

Member

What would be the purpose of this special labels? Where would it be used? And why would not be it mapped a color? If you think assigning normal label does not make sense for dom0, IMO better drop this property at all, instead of introducing yet another special case.

Member

marmarek commented Sep 22, 2017

What would be the purpose of this special labels? Where would it be used? And why would not be it mapped a color? If you think assigning normal label does not make sense for dom0, IMO better drop this property at all, instead of introducing yet another special case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment