Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updom0 label discrepancy #3102
Comments
rootkovska
added
bug
C: desktop-linux
P: minor
labels
Sep 20, 2017
rootkovska
added this to the Release 4.0 milestone
Sep 20, 2017
rootkovska
assigned
marmarek
Sep 20, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Sep 20, 2017
Member
Window manager do not know what label is set by qvm-prefs, because dom0 windows are not created by gui-daemon (so do not have _QUBES_* X properties). I think we should forbid changing dom0 label and set it the same in both qvm-prefs and window managers. What color do you prefer?
|
Window manager do not know what label is set by qvm-prefs, because dom0 windows are not created by gui-daemon (so do not have |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
How about some special kind of color, say: "adminvm"? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Sep 21, 2017
Member
Why? Would that be a color outside of any color palette? ;)
Alternatively, we may drop 'label' property from dom0 at all.
|
Why? Would that be a color outside of any color palette? ;) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rootkovska
Sep 22, 2017
Member
Note the property is called "label", not "color" :) So, yeah, the idea is to have something special reserved for this. Also, in the future we will likely introduce another label perhaps: "guidom"?
|
Note the property is called "label", not "color" :) So, yeah, the idea is to have something special reserved for this. Also, in the future we will likely introduce another label perhaps: "guidom"? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Sep 22, 2017
Member
What would be the purpose of this special labels? Where would it be used? And why would not be it mapped a color? If you think assigning normal label does not make sense for dom0, IMO better drop this property at all, instead of introducing yet another special case.
|
What would be the purpose of this special labels? Where would it be used? And why would not be it mapped a color? If you think assigning normal label does not make sense for dom0, IMO better drop this property at all, instead of introducing yet another special case. |
rootkovska commentedSep 20, 2017
qvm-prefs reports dom0 label as black. Our Windows Manager plugin displays the gray/silver label.