New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-admin: separate xml loading #3123

Closed
marmarek opened this Issue Sep 26, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@marmarek
Member

marmarek commented Sep 26, 2017

This was done when all objects kept reference to their respective XML object
for saving. This is no longer needed since there is no concurrent access to XML
from different tools anymore.

PropertyHolder.from_xml(), to be overloaded in children. Care should be taken
when loading properties wrt loading order.

@marmarek marmarek added this to the Release 4.0 milestone Sep 26, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 27, 2018

Member

@woju do we still want this?

Member

marmarek commented Feb 27, 2018

@woju do we still want this?

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 18, 2018

Member

No, I don't think it is important. Currently things work, so don't fix if it ain't broken.

Member

woju commented Apr 18, 2018

No, I don't think it is important. Currently things work, so don't fix if it ain't broken.

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 18, 2018

Member

This issue is abandoned, so I'm going to close it. If that's a mistake, feel free to reopen.
@marmarek @andrewdavidwong

Member

woju commented Apr 18, 2018

This issue is abandoned, so I'm going to close it. If that's a mistake, feel free to reopen.
@marmarek @andrewdavidwong

@woju woju closed this Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment