Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upqvm-remove may cause unwanted data loss (typos etc.) #3129
Comments
3hhh
changed the title from
qvm-remove may cause data loss quickly
to
qvm-remove may cause unwanted data loss (typos etc.)
Sep 27, 2017
marmarek
added
C: core
enhancement
P: major
P: minor
and removed
P: major
labels
Sep 27, 2017
marmarek
added this to the Release 4.0 milestone
Sep 27, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
Nov 9, 2017
Seems like a related issue:
qvm-remove will remove a Template that is installed from dnf/rpm. Is that intended?
tasket
commented
Nov 9, 2017
|
Seems like a related issue: qvm-remove will remove a Template that is installed from dnf/rpm. Is that intended? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
commented
Dec 20, 2017
|
@marmarek - I have a patch I can add to PR#43 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Dec 20, 2017
Member
@marmarek - I have a patch I can add to PR#43
Please create separate PR.
Please create separate PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
Dec 29, 2017
@marmarek - Should I put a check/exception for installed_by_rpm in api/admin.py: vm_remove() ?
tasket
commented
Dec 29, 2017
|
@marmarek - Should I put a check/exception for |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
commented
Dec 29, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
commented
Dec 30, 2017
tasket
referenced this issue
Dec 30, 2017
Closed
'installed_by_rpm' is False after template installation #3435
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tasket
commented
Jan 10, 2018
|
@3hhh - You can probably close this now; The above PRs were merged. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks @tasket ! |
3hhh commentedSep 27, 2017
Qubes OS version (e.g.,
R3.2):4.0rc1
Steps to reproduce the behavior:
qvm-remove [VM]Actual behavior:
It removes the VM.
Expected behavior:
It could provide some security check that you didn't mistype or anything. This was available in Qubes Manager in 3.2.
A
-fflag might force removal without a second question for scripting etc.