/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-copy-to-vm useless target parameter #3141

Closed
3hhh opened this Issue Oct 1, 2017 · 16 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
4 participants
@3hhh @andrewdavidwong @marmarek @qubesos-bot
@3hhh

3hhh commented Oct 1, 2017

Qubes OS version (e.g., R3.2):

4.0rc1

Steps to reproduce the behavior:

  1. qvm-copy-to-vm [target VM] [file]

  2. Choose a different target VM in the dom0 dialog

Expected behavior:

No [target VM] parameter needed.

Actual behavior:

It is needed and has no effect.

@andrewdavidwong andrewdavidwong added the C: core label Oct 1, 2017

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Oct 1, 2017

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 1, 2017

Member

Not sure if this is actually intended (e.g., due to RPC policy interaction). @marmarek?
Member

andrewdavidwong commented Oct 1, 2017

Not sure if this is actually intended (e.g., due to RPC policy interaction). @marmarek?
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 1, 2017

Member

Yes, this is intended effect. Target parameter is now useless with default policy. But it can be still meaningful with custom policy (containing "allow" action for selected targets). Target parameter in that tool is kept for compatibility reasons. This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...
We have considered new tool (a simple wrapper) without that parameter, but haven't got any idea for the name (to not be confusing with existing one). Any idea?
Member

marmarek commented Oct 1, 2017

Yes, this is intended effect. Target parameter is now useless with default policy. But it can be still meaningful with custom policy (containing "allow" action for selected targets). Target parameter in that tool is kept for compatibility reasons. This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...
We have considered new tool (a simple wrapper) without that parameter, but haven't got any idea for the name (to not be confusing with existing one). Any idea?
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 1, 2017

Member

This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...

Can you provide an example?

We have considered new tool (a simple wrapper) without that parameter, but haven't got any idea for the name (to not be confusing with existing one). Any idea?

qvm-copy
qvm-move

Rationale: Drop -to-vm from the name of the command, since the target VM is no longer specified as an argument to the command (but rather in a subsequent prompt).
Member

andrewdavidwong commented Oct 1, 2017

This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...

Can you provide an example?

We have considered new tool (a simple wrapper) without that parameter, but haven't got any idea for the name (to not be confusing with existing one). Any idea?

qvm-copy
qvm-move

Rationale: Drop -to-vm from the name of the command, since the target VM is no longer specified as an argument to the command (but rather in a subsequent prompt).
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 1, 2017

Member

This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...

Can you provide an example?

Sure: #2472

qvm-copy
qvm-move

+1
Member

marmarek commented Oct 1, 2017

This is especially important for qvm-move-to-vm - it could be fatal if you have a file/directory with the name of the target VM in the same place...

Can you provide an example?

Sure: #2472

qvm-copy
qvm-move

+1
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 2, 2017

Member

Sure: #2472

Ah, I see!
Member

andrewdavidwong commented Oct 2, 2017

Sure: #2472

Ah, I see!
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 2, 2017

Member

Closing as notanissue since the reported behavior is intended.
Member

andrewdavidwong commented Oct 2, 2017

Closing as notanissue since the reported behavior is intended.

@andrewdavidwong andrewdavidwong closed this Oct 2, 2017

@andrewdavidwong andrewdavidwong added the notanissue label Oct 2, 2017

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 2, 2017

@marmarek
Add convenient wrappers for qvm-copy-to-vm and qvm-move-to-vm 
Default `ask` policy ignore target domain specified by the caller, so it
doesn't make sense to specify one. Provide convenient wrappers not
needing one. Do not change behaviour of existing tools for compatibility
reasons.

Fixes QubesOS/qubes-issues#3141
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
deb702a

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 2, 2017

@marmarek
Add convenient wrappers for qvm-copy-to-vm and qvm-move-to-vm 
Default `ask` policy ignore target domain specified by the caller, so it
doesn't make sense to specify one. Provide convenient wrappers not
needing one. Do not change behaviour of existing tools for compatibility
reasons.

Fixes QubesOS/qubes-issues#3141
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
486f17e
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-jessie-cur-test label Oct 7, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Oct 7, 2017

Closed

core-agent-linux v4.0.11 (r4.0) #249

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-stretch-cur-test label Oct 7, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-fc24-cur-test label Oct 7, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-fc25-cur-test label Oct 7, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc26 has been pushed to the r4.0 testing repository for the Fedora fc26 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc26 has been pushed to the r4.0 testing repository for the Fedora fc26 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-fc26-cur-test label Oct 7, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 7, 2017

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Oct 7, 2017

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-centos7-cur-test label Oct 7, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 17, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc24 has been pushed to the r4.0 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Oct 17, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc24 has been pushed to the r4.0 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-fc24-stable and removed r4.0-fc24-cur-test labels Oct 17, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 17, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Oct 17, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-fc25-stable and removed r4.0-fc25-cur-test labels Oct 17, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 17, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb8u1 has been pushed to the r4.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Oct 17, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb8u1 has been pushed to the r4.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-jessie-stable and removed r4.0-jessie-cur-test labels Oct 17, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 17, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Oct 17, 2017

Automated announcement from builder-github

The package qubes-core-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-stretch-stable and removed r4.0-stretch-cur-test labels Oct 17, 2017

@andrewdavidwong andrewdavidwong referenced this issue Feb 14, 2018

Open

qvm-copy target selection via cli #3584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment