/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing VM system storage max. size via GUI not working (R4.0rc1) #3143

Closed
0spinboson opened this Issue Oct 3, 2017 · 10 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
4 participants
@0spinboson @marmarek @qubesos-bot @andrewdavidwong
@0spinboson

0spinboson commented Oct 3, 2017 •
edited
Edited 1 time
  • @0spinboson 0spinboson edited Oct 3, 2017 (most recent)

Qubes OS version (e.g., R3.2):

R4.0-rc1, up to date with current-testing

Affected TemplateVMs (e.g., fedora-23, if applicable):

dom0

Steps to reproduce the behavior:

open VM settings GUI for any VM, increase the system max. storage size, click OK.

Expected behavior:

increases storage size for the root.img

Actual behavior:

errors out, and appears to be trying to apply the private storage max size to the system storage max size. (E.g. in a VM with 3GB private 10gb system I get an error/warning that I can't decrease the size using this UI, and that I must use truncate if I really want this. In another VM the reported system storage max size has been increased to 68GB (the private max that was already set), though it didn't actually increase the system volume storage max size -- inside the VM it's still set at 10.5GB.
log3.txt

@0spinboson 0spinboson changed the title from changing system storage max. size via GUI not working (R4.0rc1) to changing VM system storage max. size via GUI not working (R4.0rc1) Oct 3, 2017

@andrewdavidwong andrewdavidwong added bug C: core labels Oct 4, 2017

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Oct 4, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 6, 2017

Member

Fix already queued:
QubesOS/qubes-core-admin@6091bbb
marmarek/qubes-core-agent-linux@a59ac1b
Member

marmarek commented Oct 6, 2017

Fix already queued:
QubesOS/qubes-core-admin@6091bbb
marmarek/qubes-core-agent-linux@a59ac1b

@marmarek marmarek closed this Oct 6, 2017

@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Oct 7, 2017

This doesn't appear to have fixed the issue. When I try to increase a VM's System storage max size, I now get a warning that shrinking of the root is disabled.

0spinboson commented Oct 7, 2017

This doesn't appear to have fixed the issue. When I try to increase a VM's System storage max size, I now get a warning that shrinking of the root is disabled.
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 7, 2017

Member

Have you installed qubes-core-dom0 4.0.8 (from testing repo)?
Member

marmarek commented Oct 7, 2017

Have you installed qubes-core-dom0 4.0.8 (from testing repo)?
@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Oct 7, 2017

Yes, I've installed all of last night's updates, so I figured I'd test it.

0spinboson commented Oct 7, 2017 •
edited
Edited 1 time
  • @0spinboson 0spinboson edited Oct 7, 2017 (most recent)

Yes, I've installed all of last night's updates, so I figured I'd test it.

@marmarek marmarek reopened this Oct 7, 2017

@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Oct 8, 2017

Precise error when I try to increase the size:
Oct 08 14:23:06 dom0 qubesd[2962]: StoragePoolException('For your own safety, shrinking of root is disabled. If you really know what you are doing, use truncate on appvms/w7/root manually.',) while calling src=b'dom0' meth=b'admin.vm.volume.Resize' dest=b'w7' arg=b'root' len(untrusted_payload)=10

0spinboson commented Oct 8, 2017 •
edited
Edited 1 time
  • @0spinboson 0spinboson edited Oct 8, 2017 (most recent)

Precise error when I try to increase the size:
Oct 08 14:23:06 dom0 qubesd[2962]: StoragePoolException('For your own safety, shrinking of root is disabled. If you really know what you are doing, use truncate on appvms/w7/root manually.',) while calling src=b'dom0' meth=b'admin.vm.volume.Resize' dest=b'w7' arg=b'root' len(untrusted_payload)=10

@marmarek marmarek closed this in marmarek/qubes-manager@0c5a2b1 Oct 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 9, 2017

Automated announcement from builder-github

The package qubes-manager-4.0.6-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Oct 9, 2017

Automated announcement from builder-github

The package qubes-manager-4.0.6-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Oct 9, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Oct 9, 2017

Closed

manager v4.0.6 (r4.0) #258

@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Oct 10, 2017

By the way: is it intentional that size increases no longer apply to running VMs? I seem to recall that in R3.2 you could just grow these while the VM was running, but now it doesn't seem to realize its size has been increased until the next boot.

0spinboson commented Oct 10, 2017

By the way: is it intentional that size increases no longer apply to running VMs? I seem to recall that in R3.2 you could just grow these while the VM was running, but now it doesn't seem to realize its size has been increased until the next boot.
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 10, 2017

Member

You mean private storage or system storage? For private it should work immediately. If it doesn't, it's a bug.
Member

marmarek commented Oct 10, 2017

You mean private storage or system storage? For private it should work immediately. If it doesn't, it's a bug.
@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Oct 10, 2017

okay, then it's bugged. :)

0spinboson commented Oct 10, 2017

okay, then it's bugged. :)

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Add support for new root volume partition layout to qubes.ResizeDisk 
If root filesystem is the last partition (new layout), resize it
in-place. Use 'parted' tool because it can resize just one partition,
without need to specify the whole new partition table. Since the
partition is mounted, parted is unhappy to modify it. Force it by
answering to its interactive prompts, and add (apparently not
documented) ---pretend-input-tty to use those answers even
though stdin is not a tty. Split the operation into multiple parted
calls, for more reliable interactive prompts handling.

Qubes 3.x disk layout (no partition table) is also supported, but the
one that was used in Qubes 4.0 rc1 (root filesystem as the first
partition) is not.

Fixes QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4abee4c

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Resize root filesystem at VM startup if needed 
Check if root device was enlarged while domain was powered off and
resize the filesystem in such a case.

QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
7b4d453

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Add support for new root volume partition layout to qubes.ResizeDisk 
If root filesystem is the last partition (new layout), resize it
in-place. Use 'parted' tool because it can resize just one partition,
without need to specify the whole new partition table. Since the
partition is mounted, parted is unhappy to modify it. Force it by
answering to its interactive prompts, and add (apparently not
documented) ---pretend-input-tty to use those answers even
though stdin is not a tty. Split the operation into multiple parted
calls, for more reliable interactive prompts handling.

Qubes 3.x disk layout (no partition table) is also supported, but the
one that was used in Qubes 4.0 rc1 (root filesystem as the first
partition) is not.

Fixes QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
d8a2b8c

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Resize root filesystem at VM startup if needed 
Check if root device was enlarged while domain was powered off and
resize the filesystem in such a case.

QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
0bcde95

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Resize root filesystem at VM startup if needed 
Check if root device was enlarged while domain was powered off and
resize the filesystem in such a case.

QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
Loading status checks…
f77e130

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Oct 18, 2017

@marmarek
Resize root filesystem at VM startup if needed 
Check if root device was enlarged while domain was powered off and
resize the filesystem in such a case.

QubesOS/qubes-issues#3173
QubesOS/qubes-issues#3143
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
1ed6e61

@marmarek marmarek referenced this issue in QubesOS/qubes-core-agent-linux Oct 18, 2017

Merged

Handle resize of root filesystem with new partition layout #61

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Oct 19, 2017

Closed

core-agent-linux v4.0.12 (r4.0) #277

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package qubes-manager-4.0.8-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Oct 30, 2017

Automated announcement from builder-github

The package qubes-manager-4.0.8-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-dom0-stable and removed r4.0-dom0-cur-test labels Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment