qubes manager throws an exception when quickly restarting an AppVM

[marmarek]

Reported by joanna on 28 Jul 2011 19:06 UTC
When I shutdown, and the quickly start again the same VM, the manager usually shows this eception:

TypeError: can't compare datetime.datetime to strat line 332 of file main.py

After I dismiss the message window, it continues to work fine though.

Migrated-From: https://wiki.qubes-os.org/ticket/315

[marmarek]

Modified by joanna on 1 Aug 2011 19:09 UTC

[marmarek]

Modified by joanna on 1 Aug 2011 19:09 UTC

[marmarek]

Modified by joanna on 10 Sep 2011 08:17 UTC

[marmarek]

Modified by joanna on 10 Sep 2011 08:17 UTC

[marmarek]

Comment by joanna on 14 Sep 2011 18:14 UTC
Seems like the problem is in this code:

if not vm.is_running() or vm.get_start_time() >= datetime.utcnow() - timedelta(0,vm_shutdown_timeout/1000):

specifically, if a VM has been 'running' at the time of the first condition check (not vm.is_running), but later became '!running' and so the vm.get_start_time() returns something that is not of type datatime.

[marmarek]

Comment by joanna on 14 Sep 2011 18:14 UTC
Seems like the problem is in this code:

if not vm.is_running() or vm.get_start_time() >= datetime.utcnow() - timedelta(0,vm_shutdown_timeout/1000):

specifically, if a VM has been 'running' at the time of the first condition check (not vm.is_running), but later became '!running' and so the vm.get_start_time() returns something that is not of type datatime.

[marmarek]

Comment by marmarek on 1 Oct 2011 08:35 UTC
http://git.qubes-os.org/?p=marmarek/core.git;a=commit;h=3c7f8b97cda961e74e256019b2d6782c14275a03
http://git.qubes-os.org/?p=marmarek/qubes-manager.git;a=commit;h=384dbf4d9cf8435b23ea24c46f0bf4b4d5ce5c70

[marmarek]

Comment by marmarek on 1 Oct 2011 08:35 UTC
http://git.qubes-os.org/?p=marmarek/core.git;a=commit;h=3c7f8b97cda961e74e256019b2d6782c14275a03
http://git.qubes-os.org/?p=marmarek/qubes-manager.git;a=commit;h=384dbf4d9cf8435b23ea24c46f0bf4b4d5ce5c70