New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative error message for `qvm-pci a` on halted VMs #3195

Closed
3hhh opened this Issue Oct 19, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@3hhh

3hhh commented Oct 19, 2017

Qubes OS version:

4.0rc1, current testing repo updates

Steps to reproduce the behavior:

Shutdown [AppVM]

qvm-pci a [AppVM] dom0:[device]
Devices can only be attached  non-persistent to a running vm

Expected behavior:

[device] is permanently attached to [AppVM]

Actual behavior:

Output of Devices can only be attached non-persistent to a running vm and no action.

General notes:

Starting the VM and then attaching it tends to work, but only for the runtime of the VM.

Was tested with an AppVM and a DispVM, both were affected.

Using qubes-vm-settings to attach a device works (even though that tends to segfault on exit quite often).

@3hhh 3hhh changed the title from qvm-pci a doesn't work to qvm-pci a doesn't work for stopped VMs Oct 19, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 19, 2017

Member

You need -p (or --persistent) option for that.

Member

marmarek commented Oct 19, 2017

You need -p (or --persistent) option for that.

@marmarek marmarek closed this Oct 19, 2017

@3hhh

This comment has been minimized.

Show comment
Hide comment
@3hhh

3hhh Oct 19, 2017

Ok, my bad then, sorry. The error was quite misleading though...

3hhh commented Oct 19, 2017

Ok, my bad then, sorry. The error was quite misleading though...

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 19, 2017

Member

Reopening as a UX issue for the error message, if it's OK with @marmarek.

Member

andrewdavidwong commented Oct 19, 2017

Reopening as a UX issue for the error message, if it's OK with @marmarek.

@andrewdavidwong andrewdavidwong changed the title from qvm-pci a doesn't work for stopped VMs to More informative error message for `qvm-pci a` on halted VMs Oct 19, 2017

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Oct 19, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 20, 2017

Member

What about "VM not running, can only attach device with persistent flag"?

Member

marmarek commented Oct 20, 2017

What about "VM not running, can only attach device with persistent flag"?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 20, 2017

Member

Sounds good to me.

Member

andrewdavidwong commented Oct 20, 2017

Sounds good to me.

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Oct 20, 2017

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Oct 21, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 21, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Oct 21, 2017

Closed

core-admin v4.0.11 (r4.0) #284

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment