/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI Qubes 4.0 EFI initrd made by installer does not include default keyboard layout setting (for disk encryption password) #3234

Closed
qubesuser opened this Issue Oct 27, 2017 · 9 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
6 participants
@qubesuser @diffusae @JorgenRask @marmarek @qubesos-bot @andrewdavidwong
@qubesuser

qubesuser commented Oct 27, 2017

Qubes OS version:

4.0-rc2

Steps to reproduce the behavior:

  1. Start Qubes installation using EFI boot
  2. Set a non-US keyboard layout
  3. Enable encryption with a passphrase including symbols that are typed differently in that keyboard layout
  4. Complete the installation
  5. Boot the system and try to decrypt the disk by typing the passphrase assuming the selected keyboard layout

Expected behavior:

It works.

Actual behavior:

It doesn't because the keyboard layout is set to us.

General notes:

It seems that the initrd, at least for EFI installation, gets created with the us keyboard layout as opposed to the user-selected one.

The issue is corrected by manually recreating the initrd with dracut on the newly installed system, but the installer should be doing that.

Not sure if the issue is present for non-EFI GRUB installations.

@andrewdavidwong andrewdavidwong added bug C: installer labels Oct 28, 2017

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Oct 28, 2017

@pallix pallix referenced this issue Jan 10, 2018

Closed

Keyboard layout does not persist in installer #3352

@andrewdavidwong andrewdavidwong referenced this issue Mar 27, 2018

Closed

Graphical Installer: Wrong keyboard layout for Grub / LUKS #3748

@diffusae

This comment has been minimized.

Show comment
Hide comment
@diffusae

diffusae Mar 27, 2018

Yes, the issue is also present for non-EFI GRUB installations.

diffusae commented Mar 27, 2018

Yes, the issue is also present for non-EFI GRUB installations.
@JorgenRask

This comment has been minimized.

Show comment
Hide comment
@JorgenRask

JorgenRask Mar 27, 2018

In start of installation I changed keyboard layout (to danish keyboard). I noticed that during the installation process the keyboard changed back to US. I'm pretty sure the keyboard layout was still DK at step 788 of 1019, but at step 793 of 1019 the keyboard was changed to US. So I had to be careful when creating my default user and set the password - I viewed the password in cleartext and could see that some of the special characters in the password were actually typed with US keyboard).
This was QubesOS4.0-rc5

JorgenRask commented Mar 27, 2018 •
edited
Edited 1 time
  • @JorgenRask JorgenRask edited Mar 27, 2018 (most recent)

In start of installation I changed keyboard layout (to danish keyboard). I noticed that during the installation process the keyboard changed back to US. I'm pretty sure the keyboard layout was still DK at step 788 of 1019, but at step 793 of 1019 the keyboard was changed to US. So I had to be careful when creating my default user and set the password - I viewed the password in cleartext and could see that some of the special characters in the password were actually typed with US keyboard).
This was QubesOS4.0-rc5
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 28, 2018

Member

@JorgenRask your issue looks rather like #3352.
Member

marmarek commented Mar 28, 2018

@JorgenRask your issue looks rather like #3352.
@JorgenRask

This comment has been minimized.

Show comment
Hide comment
@JorgenRask

JorgenRask Mar 28, 2018

@marmarek could be :-) I just wanted to add the observation that I could see the keyboard layout change (in the upper right corner of the screen) during the installation process and was not just happening when you tried to create a user. It looks like you have reproduced the problem, so I will not add any more to this ;-)

JorgenRask commented Mar 28, 2018

@marmarek could be :-) I just wanted to add the observation that I could see the keyboard layout change (in the upper right corner of the screen) during the installation process and was not just happening when you tried to create a user. It looks like you have reproduced the problem, so I will not add any more to this ;-)

@marmarek marmarek closed this in marmarek/qubes-core-admin-linux@bcf7c9e Mar 28, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 28, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.14-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Mar 28, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.14-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Mar 28, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Mar 28, 2018

Closed

core-admin-linux v4.0.14 (r4.0) #466

This was referenced Apr 1, 2018

Closed
Closed
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Apr 18, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.14-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Apr 18, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.14-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-dom0-stable and removed r4.0-dom0-cur-test labels Apr 18, 2018

@marmarek marmarek reopened this Jun 27, 2018

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 27, 2018

Member

According to https://openqa.qubes-os.org/tests/118 it is still an issue.
Member

marmarek commented Jun 27, 2018

According to https://openqa.qubes-os.org/tests/118 it is still an issue.

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Jun 27, 2018

@marmarek
kernel-install: fix initramfs copying scripts order 
50-dracut generates initramfs in /boot/(efi/)?/$MACHINE_ID/.../initrd
80-grub2 copies it to /boot/initramfs-....img
90-xen-efi copies it to /boot/efi/EFI/qubes/initramfs-....img

Make the above order explicit, rather than relying on xen sorted later
than grub2.

QubesOS/qubes-issues#3234
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
2f55f09

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Jun 28, 2018

@marmarek
kernel-install: fix initramfs copying scripts 
Fix current EFI boot dir discovery script.

Also, adjust scripts order:
50-dracut generates initramfs in /boot/(efi/)?/$MACHINE_ID/.../initrd
80-grub2 copies it to /boot/initramfs-....img
90-xen-efi copies it to /boot/efi/EFI/qubes/initramfs-....img

Make the above order explicit, rather than relying on xen sorted later
than grub2.

QubesOS/qubes-issues#3234
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
9eefe23

@marmarek marmarek closed this in marmarek/qubes-core-admin-linux@53730c4 Jul 3, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 3, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.15-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Jul 3, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.15-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Jul 3, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 3, 2018

Closed

core-admin-linux v4.0.15 (r4.0) #571

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 23, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.15-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Jul 23, 2018

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.15-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-dom0-stable and removed r4.0-dom0-cur-test labels Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment