qvm-sync-appmenus doesn't respect OnlyShowIn and NotShowIn resulting in duplicate entries on Ubuntu

[qubesuser]

Qubes OS version:

R4.0-rc2

Affected TemplateVMs:

ubuntu 17.10

Steps to reproduce the behavior:

1. Install an Ubuntu template VM
2. Sync appmenus

Expected behavior:

There is only one "Files" appmenu.

Actual behavior:

There are two "Files" appmenus.

General notes:

Ubuntu has org.gnome.Nautilus.desktop with "OnlyShowIn=Unity;GNOME;" and nautilus.desktop with "NotShowIn=Unity;GNOME;"

Thus, with a proper implementation only one can be shown regardless of what "desktop name" the implementation considers itself to be, while Qubes seems to just ignore those directives resulting in duplication.

I think Qubes might also want to pretend to be "GNOME", although this is not totally clear.

[marmarek]

This is semi-intentional - to allow using any application, regardless of its native desktop environment. While this particular application provide both desktop files, there are a lot of them that provide only one (for example with OnlyShowIn=KDE;, or OnlyShowIn=GNOME;). For example nautilus, or gnome contacts, or baobab in Fedora are such cases.
We may add a tooltip in that window to help distinguishing such corner cases - for example desktop file name.

[marmarek]

This is semi-intentional - to allow using any application, regardless of its native desktop environment. While this particular application provide both desktop files, there are a lot of them that provide only one (for example with OnlyShowIn=KDE;, or OnlyShowIn=GNOME;). For example nautilus, or gnome contacts, or baobab in Fedora are such cases.
We may add a tooltip in that window to help distinguishing such corner cases - for example desktop file name.

[qubesuser]

I see.

I guess the solution could then be to deduplicate desktop entries that have the same Name= and same Exec= line (after removing %f, %F, %u, %U from the exec line and canonicalizing whitespace).

It's not really a big deal though.

[qubesuser]

I see.

I guess the solution could then be to deduplicate desktop entries that have the same Name= and same Exec= line (after removing %f, %F, %u, %U from the exec line and canonicalizing whitespace).

It's not really a big deal though.

[marmarek]

I guess those do have different Exec= lines... Or at least one have DBusActivable=true (which also result in something different being executed in practice)

[marmarek]

I guess those do have different Exec= lines... Or at least one have DBusActivable=true (which also result in something different being executed in practice)

[qubesuser]

Yes, one has %U at the end, but the spec says it should be removed when not opening any files, and thus the Exec= lines are logically equivalent for the purpose of application menus.

If there is already logic to avoid duplicate exec lines, then it looks like it only needs to be updated to do s/%[fFuU]//g; s/\s+/ /g; s/^\s+//; s/\s+$//; before comparing.

[qubesuser]

Yes, one has %U at the end, but the spec says it should be removed when not opening any files, and thus the Exec= lines are logically equivalent for the purpose of application menus.

If there is already logic to avoid duplicate exec lines, then it looks like it only needs to be updated to do s/%[fFuU]//g; s/\s+/ /g; s/^\s+//; s/\s+$//; before comparing.