Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCannot change revisions_to_keep for a storage pool #3256
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Oct 29, 2017
Member
I'm already working on this. Better not change this (or any other) value manually in qubes.xml, because driver may want to apply some constrains, or do some conversion when changing it.
|
I'm already working on this. Better not change this (or any other) value manually in qubes.xml, because driver may want to apply some constrains, or do some conversion when changing it. |
andrewdavidwong
added
bug
C: core
labels
Oct 29, 2017
andrewdavidwong
added this to the Release 4.0 milestone
Oct 29, 2017
marmarek
self-assigned this
Nov 6, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Nov 7, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Nov 7, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Nov 7, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Nov 7, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Nov 7, 2017
qubesos-bot
referenced this issue
in QubesOS/updates-status
Nov 21, 2017
Closed
core-admin v4.0.12 (r4.0) #313
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tlaurion
Feb 7, 2018
Contributor
@marmarek is it supposed to work? In 4.0 rc4, qvm-pool -i lvm -o revisions_to_keep=3 doesn't have any effect.
|
@marmarek is it supposed to work? In 4.0 rc4, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 11, 2018
Member
qvm-pool -i just display information, it isn't supposed to change anything. This ticket is about adding an option for that... For now the backend side (Admin API) is already done.
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tlaurion
Feb 15, 2018
Contributor
@marmarek I tried to change manually qubes.xml (revisions_to_keep=3) with same result.
Any manual operations to make the backend take it in consideration atm?
I'm looking into that feature to make some changes to dom0 to update Qubes Network Server internals, and revert easily when messing up.
|
@marmarek I tried to change manually qubes.xml ( Any manual operations to make the backend take it in consideration atm? I'm looking into that feature to make some changes to dom0 to update Qubes Network Server internals, and revert easily when messing up. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rustybird
Feb 15, 2018
I tried to change manually qubes.xml (revisions_to_keep=3) with same result.
Any manual operations to make the backend take it in consideration atm?
Setting revisions_to_keep in the individual <volume> elements (not just once in <pool>) looks like it would work for the lvm_thin driver. But I haven't tried it.
rustybird
commented
Feb 15, 2018
Setting |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 15, 2018
Member
You can also use Admin API directly, until proper UI get implemented:
echo -n 2 | qubesd-query dom0 admin.vm.volume.Set.revisions_to_keep <VMNAME> <VOLUME>
|
You can also use Admin API directly, until proper UI get implemented:
|
added a commit
to marmarek/qubes-core-admin-client
that referenced
this issue
Mar 18, 2018
added a commit
to marmarek/qubes-core-admin-client
that referenced
this issue
Mar 18, 2018
added a commit
to marmarek/qubes-core-admin-client
that referenced
this issue
Mar 18, 2018
added a commit
to marmarek/qubes-core-admin-client
that referenced
this issue
Mar 18, 2018
marmarek
referenced this issue
in QubesOS/qubes-core-admin-client
Mar 19, 2018
Merged
Improve qvm-volume tool #60
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Mar 19, 2018
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Mar 19, 2018
marmarek
closed this
in
marmarek/qubes-core-admin-client@034e9b3
Mar 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Mar 21, 2018
Automated announcement from builder-github
The package python2-qubesadmin-4.0.16-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
qubesos-bot
commented
Mar 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-dom0-cur-test
label
Mar 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Mar 21, 2018
Automated announcement from builder-github
The package core-admin-client has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Mar 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-centos7-cur-test
label
Mar 21, 2018
qubesos-bot
referenced this issue
in QubesOS/updates-status
Mar 21, 2018
Closed
core-admin-client v4.0.16 (r4.0) #455
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Mar 21, 2018
Automated announcement from builder-github
The component core-admin-client (including package python2-qubesadmin-4.0.16-0.1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Mar 21, 2018
|
Automated announcement from builder-github The component
|
qubesos-bot
added
the
r4.0-fc26-cur-test
label
Mar 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Mar 21, 2018
Automated announcement from builder-github
The package qubes-core-admin-client_4.0.16-1+deb10u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Mar 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-buster-cur-test
r4.0-jessie-cur-test
labels
Mar 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Mar 21, 2018
Automated announcement from builder-github
The package qubes-core-admin-client_4.0.16-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Mar 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-stretch-cur-test
label
Mar 21, 2018
qubesos-bot
referenced this issue
in QubesOS/updates-status
Mar 29, 2018
Closed
core-admin v4.0.25 (r4.0) #469
added a commit
to marmarek/qubes-core-admin-client
that referenced
this issue
Apr 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Apr 18, 2018
Automated announcement from builder-github
The package qubes-core-admin-client_4.0.16-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Apr 18, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-stretch-stable
and removed
r4.0-stretch-cur-test
labels
Apr 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Apr 21, 2018
Automated announcement from builder-github
The package python2-qubesadmin-4.0.17-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
qubesos-bot
commented
Apr 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-dom0-cur-test
label
Apr 21, 2018
qubesos-bot
referenced this issue
in QubesOS/updates-status
Apr 21, 2018
Closed
core-admin-client v4.0.17 (r4.0) #488
qubesos-bot
added
r4.0-buster-cur-test
r4.0-jessie-cur-test
labels
Apr 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Apr 21, 2018
Automated announcement from builder-github
The component core-admin-client (including package python2-qubesadmin-4.0.17-0.1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Apr 21, 2018
|
Automated announcement from builder-github The component
|
qubesos-bot
added
the
r4.0-fc26-cur-test
label
Apr 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Apr 21, 2018
Automated announcement from builder-github
The package qubes-core-admin-client_4.0.17-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Apr 21, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-stretch-cur-test
label
Apr 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 1, 2018
Automated announcement from builder-github
The package core-admin-client has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
May 1, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-centos7-cur-test
label
May 1, 2018
qubesos-bot
added
r4.0-buster-stable
r4.0-jessie-stable
and removed
r4.0-buster-cur-test
r4.0-jessie-cur-test
labels
May 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 14, 2018
Automated announcement from builder-github
The package qubes-core-admin-client_4.0.17-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
May 14, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-stretch-stable
and removed
r4.0-stretch-cur-test
labels
May 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 14, 2018
Automated announcement from builder-github
The package core-admin-client has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
May 14, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-centos7-stable
and removed
r4.0-centos7-cur-test
labels
May 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 14, 2018
Automated announcement from builder-github
The component core-admin-client (including package python2-qubesadmin-4.0.17-0.1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
May 14, 2018
|
Automated announcement from builder-github The component
|
qubesos-bot
added
r4.0-fc26-stable
and removed
r4.0-fc26-cur-test
labels
May 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 14, 2018
Automated announcement from builder-github
The package python2-qubesadmin-4.0.17-0.1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:
sudo qubes-dom0-update
Or update dom0 via Qubes Manager.
qubesos-bot
commented
May 14, 2018
|
Automated announcement from builder-github The package
Or update dom0 via Qubes Manager. |
na-- commentedOct 29, 2017
Qubes OS version:
R4.0 RC2
Affected TemplateVMs:
none (dom0 issue)
Steps to reproduce the behavior:
Try to change the number of
revisions_to_keepfor a storage pool with theqvm-poolcommandExpected behavior:
That there is a relatively easy way to modify (or at least increase) the number of revisions kept
Actual behavior:
None such exists - probably editing
qubes.xmldirectly will do the job, but not sure if that won't mess something up.General notes:
I am not sure that it's a good idea to mess with storage pool options after a pool is created, too many things can go wrong. The exception I think is increasing
revisions_to_keep, even decreasing it can be problematic if not handled correctly. So handling such a special case inqvm-poolmight not be the best way to proceed...A workaround that I think could be used right now looks like this:
revisions_to_keepvalueIt's a bit of a mess, especially when cloning templates :) Is there an easier way to accomplish this?
Related issues:
None that I could find