New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisposableVM are duplicated in qrexec dialog #3271

Open
ERFier opened this Issue Nov 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ERFier

ERFier commented Nov 2, 2017

Qubes OS version:

R4 rc2

Affected TemplateVMs:

dom-0 qrexec dialog


Steps to reproduce the behavior:

open a file using qvm-open-in-vm '$dispvm:fedora-25-qvm' something.pdf

The qrexec-dialog pops up and gives a choice for the vm in which I want to open the file.

Expected behavior:

I would expect to see the Disposible VMs only once as its disposible version.

Actual behavior:

The disposable vms are shown twice. One time as the disposable version I usually want and another time as the regular AppVM that serves as a template for disposable VMs.

General notes:

I think it's a security issue as it's very likely that someone accidentally opens a file in the underlaying AppVM instead of the supposed DispVM. The two entries only differentiate in the DispVM logo with the circle inside the lock.


Related issues:

@ERFier

This comment has been minimized.

Show comment
Hide comment
@ERFier

ERFier Nov 2, 2017

I would like to post a screenshot as it makes very clear what I mean with accidentally choose the AppVM but I cant. Are there any constrains for pictures on github?

ERFier commented Nov 2, 2017

I would like to post a screenshot as it makes very clear what I mean with accidentally choose the AppVM but I cant. Are there any constrains for pictures on github?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Nov 2, 2017

Member

I would like to post a screenshot as it makes very clear what I mean with accidentally choose the AppVM but I cant. Are there any constrains for pictures on github?

No, you should be able to attach files by dragging & dropping, using the selection tool, or pasting it from your clipboard. Alternatively, you can upload the screenshot to an image sharing site and post the link here.

Member

andrewdavidwong commented Nov 2, 2017

I would like to post a screenshot as it makes very clear what I mean with accidentally choose the AppVM but I cant. Are there any constrains for pictures on github?

No, you should be able to attach files by dragging & dropping, using the selection tool, or pasting it from your clipboard. Alternatively, you can upload the screenshot to an image sharing site and post the link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment