New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"$anyvm $adminvm ask" policy doesn't allow confirming dom0 target #3283

Closed
jpouellet opened this Issue Nov 6, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@jpouellet
Contributor

jpouellet commented Nov 6, 2017

Qubes OS version:

R4-rc1

Steps to reproduce the behavior:

Create some dummy service:

[user@dom0 ~]$ cat /etc/qubes-rpc/test.Echo 
#!/bin/sh
printf "%s\n" "$1"

Then with various policies, try:

[user@disp427 ~]$ qrexec-client-vm dom0 test.Echo+foo

Expected behavior:

With the following policies, things work as expected:

$anyvm dom0 ask
$anyvm $adminvm ask,target=dom0

dom0 is in the dropdown list, I can type (and autocomplete) it in the target text box, no problem:
adminvm1

Actual behavior:

However, with the following policy:

$anyvm $adminvm ask

the dropdown menu is disabled, and I am unable to click OK after typing dom0:
adminvm2


Related issues:

#910

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Nov 6, 2017

@marmarek marmarek self-assigned this Nov 6, 2017

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 7, 2017

qubespolicy: fix handling '$adminvm' target with ask action
All policy keywords needs to be expanded before sending it to
confirmation dialog. $dispvm was already handled, but $adminvm was
missing

Fixes QubesOS/qubes-issues#3283

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 7, 2017

qubespolicy: fix handling '$adminvm' target with ask action
All policy keywords needs to be expanded before sending it to
confirmation dialog. $dispvm was already handled, but $adminvm was
missing

Fixes QubesOS/qubes-issues#3283
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Nov 21, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.12-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.12-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Nov 21, 2017

Closed

core-admin v4.0.12 (r4.0) #313

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Dec 12, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.14-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.14-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment