New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-clone ProxyVM with '_' char in name produces menu & VM Manager error #3301

Open
qubeling opened this Issue Nov 9, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@qubeling

qubeling commented Nov 9, 2017

Qubes OS version:

Qubes release 3.2 (R3.2)

Affected TemplateVMs:

ProxyVM built on debian-8 TemplateVM


Steps to reproduce the behavior:

  1. Create ProxyVM using debian-8 TemplateVM
  2. Open dom0 terminal, use qvm-clone on new ProxyVM
  3. Give clone a name with illegal(?) '_' character, (ie vpn_1)
  4. Attempt removal

Expected behavior:

ProxyVM deletes, removing the Applications menu shortcut with it.

Actual behavior:

ProxyVM persists in Applications menu; is not listed in VM Manager, cannot be removed from command-line (A VM with the name 'vpn_1' does not exist in the system error message) as it is quite obviously already gone.

Trying to open programs in the stuck ProxyVM predictably does nothing.

General notes:

Was cloning one of my VPN ProxyVMs and in my haste accidentally produced an underscore instead of hyphen. After experiencing related bug below (1), I removed the entire ProxyVM in order to start the cloning again. However post-removal it is still visible in the applications menu, even though it is not present either in qvm or in the GUI VM Manager. Minor, but incredibly annoying.

Could be mitigated entirely by adding a block of the underscore in qvm-clone as it does block it in GUI renaming.


Related issues:

(1) Went into VM Manager to rename, would not allow me to make a modification. The field was activated as normal, though trying to backspace did not yield results.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
Member

andrewdavidwong commented Nov 10, 2017

Related: #2422

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 13, 2018

Fixed VM name validation in GUI tools (Create VM, Settings, Manager)
VM name validation in various places in Manager did not allow
perfectly legal otherwise '_' and '.' characters.

references QubesOS/qubes-issues#2422
fixes QubesOS/qubes-issues#3301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment