qubes-dom0-update --action={upgrade,...} qubes-template-* fails

[jpouellet]

Qubes OS version:

R4-rc3

Affected TemplateVMs:

All ;)

---

Steps to reproduce the behavior:

[user@dom0 ~]$ sudo qubes-dom0-update --action=upgrade qubes-template-fedora-26-minimal
WARNING: Replacing a template will erase all files in template's /home and /rw !
Template VM halted
usage: qvm-prefs [-h] [--verbose] [--quiet] [--help-properties] [--get]
                 [--set] [--default]
                 VMNAME [PROPERTY] [VALUE]
qvm-prefs: error: no such property: 'root_img'

Expected behavior:

The template gets upgraded, discarding any user modifications.

Actual behavior:

qubes-dom0-update first tries to make a backup of the template images, which is an implicit dependency on the old storage subsystem where images were files. This fails.

General notes:

From qubes-dom0-update:

# Prevent implicit update of template - this would override user changes -
# but do allow explicit template upgrade, downgrade, reinstall
if [ "$YUM_ACTION" == "reinstall" ] || [ "$YUM_ACTION" == "upgrade" ] || [ "$YUM_ACTION" == "
upgrade-to" ] \
|| [ "$YUM_ACTION" == "downgrade" ] && [[ "$PKGS" == *"qubes-template-"* ]]; then
    TEMPLATE_EXCLUDE_OPTS=""
    echo "WARNING: Replacing a template will erase all files in template's /home and /rw !"

    ONEPKG=`cut -f 1 -d ' ' <<<$PKGS`
    if [[ "$ONEPKG" == "qubes-template-"* ]] && [[ "$ONEPKG" == "${PKGS#\ }" ]]; then # test "$PKGS" minus space
    # Prepare to backup template root.img in case reinstall doesn't complete.
        ONEPKG=`sed -r 's/-[0-9]+(\.[0-9-]+)+(\.noarch)*$//' <<<$ONEPKG` # Remove version suffix
        TEMPLATE=${ONEPKG#qubes-template-} # Remove prefix
        if qvm-shutdown --wait $TEMPLATE ; then
            echo "Template VM halted"
        fi
        if ! TEMPLATE_NETVM=`qvm-prefs --force-root $TEMPLATE netvm` \
        || ! BAK_TEMPLATE_ROOT=`qvm-prefs --force-root $TEMPLATE root_img` \
        || ! BAK_TEMPLATE_PRIVATE=`qvm-prefs --force-root $TEMPLATE private_img` ; then
            exit 1
        fi
        if [[ "$TEMPLATE_NETVM" == *"(default)" ]] ; then
            TEMPLATE_NETVM="default"
        fi
    else
        echo "ERROR: Specify only one package to reinstall template"
        exit 1
    fi

else
    TEMPLATE_EXCLUDE_OPTS="--exclude=`rpm -qa --qf '%{NAME},' qubes-template-\*`"
fi

[jpouellet]

Fixed in QubesOS/qubes-core-admin-linux#33

Forgot to add Fixes: ... to commit msg.

[jpouellet]

Fixed in QubesOS/qubes-core-admin-linux#33

Forgot to add Fixes: ... to commit msg.