New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create new qubes or open VM Settings #3475

Closed
molnara opened this Issue Jan 18, 2018 · 35 comments

Comments

Projects
None yet
6 participants
@molnara

molnara commented Jan 18, 2018

Qubes OS version:

Qubes release 4.0 (R4.0)

Affected TemplateVMs:

dom0


Steps to reproduce the behavior:

  1. sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
  2. sudo reboot (There was also a linux kernel update)
  3. Click Qubes menu
  4. Click Create Qubes VM shortcut
  5. Click Qubes menu
  6. Click any Domain: VM Settings
  7. Click Qubes menu -> System Tools -> Qube Manager
  8. Click a qube and click the cog button or right click and select Qube settings

Expected behavior:

  1. New Qubes GUI should open
  2. VM Settings GUI should open

Actual behavior:

This happens when clicking VM Settings from Qubes shortcut.

Houston, we have a problem...

Whoops. A critical error has occured.  This is most likely a bug in Qubes Manager.

TypeError: unorderable types:

builtin_function_or_method()
at line 9
of file /usr/lib/python3.5/site-packages/qubesmanager/utils.py
----
line: allow_default=False
func: __init_basic_tab__
line no: 290
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----
line: self.__init_basic_tab__()
func: __init__
line no: 83
file: /usr/lib/python3.5/site-packages/qubesmanager/settings.py
----

.....

This happens when you click the Qubes settings in the Qube Manager.

Houston, we have a problem...

Whoops. A critical error has occured.  This is most likely a bug in Qubes Manager.

TypeError: unorderable types:
builtin_function_or_method()
at line 852
of file /usr/lib/python3.5/site-packages/qubesmanager/utils.py
----
line: sorted(app.labels, key=lambda l: l.index),
func: prepare_label_choice
lineno.: 116

General notes:

I typed out that stack trace, wasn't sure how to copy/paste from dom0. (Current docs are out of date?) If someone needs more, I can type out the rest.


Related issues:

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 18, 2018

Ok, so there are actually two different critical errors. One happens when you use the VM Settings shortcut and another one when you click the Qubes Settings from the Qube Manager. I'll make an edit with the other stack trace.

molnara commented Jan 18, 2018

Ok, so there are actually two different critical errors. One happens when you use the VM Settings shortcut and another one when you click the Qubes Settings from the Qube Manager. I'll make an edit with the other stack trace.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 18, 2018

Member

When exactly have you updated? Or better, what package versions do you have, at least qubes-manger and qubes-core-admin-client? You can check it this way:

rpm -q qubes-manager qubes-core-admin-client
Member

marmarek commented Jan 18, 2018

When exactly have you updated? Or better, what package versions do you have, at least qubes-manger and qubes-core-admin-client? You can check it this way:

rpm -q qubes-manager qubes-core-admin-client
@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 18, 2018

I just updated about an hour ago.

Qubes Manager is 4.0.10-1.fc25.x86_64
Admin client is 4.0.13-0.1.fc25.noarch

molnara commented Jan 18, 2018

I just updated about an hour ago.

Qubes Manager is 4.0.10-1.fc25.x86_64
Admin client is 4.0.13-0.1.fc25.noarch

@marmarek marmarek added this to the Release 4.0 milestone Jan 18, 2018

@marmarta marmarta referenced this issue in QubesOS/qubes-manager Jan 18, 2018

Merged

Bunch of fixes for 4.0 #57

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 18, 2018

I pulled down another update from test repo and now qubes is unstable. It takes about 15 min to open firefox. Previously I had no issues running existing qubes. Also, my laptop has 16gb memory, I only was running sys-net sys-firewall and one personal cube. All using fedora-26 template downloaded fresh.

molnara commented Jan 18, 2018

I pulled down another update from test repo and now qubes is unstable. It takes about 15 min to open firefox. Previously I had no issues running existing qubes. Also, my laptop has 16gb memory, I only was running sys-net sys-firewall and one personal cube. All using fedora-26 template downloaded fresh.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 18, 2018

Member

What packages were included in that last update run?

Member

marmarek commented Jan 18, 2018

What packages were included in that last update run?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 18, 2018

Member

What kernel do you use in VMs? Was is one of updated packages this time?

Member

marmarek commented Jan 18, 2018

What kernel do you use in VMs? Was is one of updated packages this time?

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

The last update that I applied was qubes-core-dom0 4.0.17-1.fc25.x86_64. I am guessing I can just use dnf to roll this one back?

molnara commented Jan 19, 2018

The last update that I applied was qubes-core-dom0 4.0.17-1.fc25.x86_64. I am guessing I can just use dnf to roll this one back?

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

Also, I didn't change the vm kernels as I couldn't get into the vm settings unless that package changed them itself. They have always been default.

molnara commented Jan 19, 2018

Also, I didn't change the vm kernels as I couldn't get into the vm settings unless that package changed them itself. They have always been default.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

What was your previous qubes-core-dom0? 4.0.16 or 4.0.15?

Member

marmarek commented Jan 19, 2018

What was your previous qubes-core-dom0? 4.0.16 or 4.0.15?

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

It was 4.0.16

molnara commented Jan 19, 2018

It was 4.0.16

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

I tried rolling back the update but it can't find 4.0.16 now.

molnara commented Jan 19, 2018

I tried rolling back the update but it can't find 4.0.16 now.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

qubes-dom0-update --action=downgrade qubes-core-dom0-4.0.16

Anyway, I don't see anything between .16 and .17 that could cause this. There is literally one commit and I don't see how it could cause such effect.
Thing that have changed between .15 and .16 is default virt_mode from HVM to PVH. In theory this could affect performance, but I'd rather expect improvement...
Maybe related to #3466? See memory assigned to each VM and/or swap usage inside of VM.

Member

marmarek commented Jan 19, 2018

qubes-dom0-update --action=downgrade qubes-core-dom0-4.0.16

Anyway, I don't see anything between .16 and .17 that could cause this. There is literally one commit and I don't see how it could cause such effect.
Thing that have changed between .15 and .16 is default virt_mode from HVM to PVH. In theory this could affect performance, but I'd rather expect improvement...
Maybe related to #3466? See memory assigned to each VM and/or swap usage inside of VM.

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

I couldn't downgrade to 4.0.16 but 4.0.15 worked. As soon as the update completed, immediately my vms started to perform normally.

molnara commented Jan 19, 2018

I couldn't downgrade to 4.0.16 but 4.0.15 worked. As soon as the update completed, immediately my vms started to perform normally.

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

Sorry, where do I see how much memory is being used by my vms? I can't get into Vm settings because of the critical error.

molnara commented Jan 19, 2018

Sorry, where do I see how much memory is being used by my vms? I can't get into Vm settings because of the critical error.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

domains widget (Q icon), or if that doesn't work, xl list

Member

marmarek commented Jan 19, 2018

domains widget (Q icon), or if that doesn't work, xl list

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

Ok, if VM restart wasn't necessary, this is most likely related to a broken fix for #3265. That broken fix is already fixed in QubesOS/qubes-core-admin#182. Let me build 4.0.18...

Member

marmarek commented Jan 19, 2018

Ok, if VM restart wasn't necessary, this is most likely related to a broken fix for #3265. That broken fix is already fixed in QubesOS/qubes-core-admin#182. Let me build 4.0.18...

@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

Ok, I didn't realize how much memory is being used by my vms:

Dom0 4067
sys-net 384
sys-net-dm 144
sys-firewall 3194
personal 3999

Seems like the firewall is chewing it all up. My personal one only has one instance of firefox open with two tabs open including the one I am writing this on. I'll try a reboot.

molnara commented Jan 19, 2018

Ok, I didn't realize how much memory is being used by my vms:

Dom0 4067
sys-net 384
sys-net-dm 144
sys-firewall 3194
personal 3999

Seems like the firewall is chewing it all up. My personal one only has one instance of firefox open with two tabs open including the one I am writing this on. I'll try a reboot.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

It looks fine, firewall is using that much, because you have free ram. It will give it to other VMs when needed.

Member

marmarek commented Jan 19, 2018

It looks fine, firewall is using that much, because you have free ram. It will give it to other VMs when needed.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

qubes-core-dom0 4.0.18 should fix this.

Member

marmarek commented Jan 19, 2018

qubes-core-dom0 4.0.18 should fix this.

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 19, 2018

Automated announcement from builder-github

The package qubes-manager-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jan 19, 2018

Closed

manager v4.0.11 (r4.0) #369

@mirrorway

This comment has been minimized.

Show comment
Hide comment
@mirrorway

mirrorway Jan 19, 2018

With qubes-manager-4.0.11-1 I can't open vm-settings:

Whoops. A critical error occurred. This is most likely a bug in Qubes Manager.

AttributeError: default_dispvm has no default
at line 9
of file /usr/bin/qubes-vm-settings.

error.log

mirrorway commented Jan 19, 2018

With qubes-manager-4.0.11-1 I can't open vm-settings:

Whoops. A critical error occurred. This is most likely a bug in Qubes Manager.

AttributeError: default_dispvm has no default
at line 9
of file /usr/bin/qubes-vm-settings.

error.log

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 19, 2018

Member

Do you have other updates installed? Especially qubes-core-dom0 4.0.18 and qubes-core-admin-client >= 4.0.13

Member

marmarek commented Jan 19, 2018

Do you have other updates installed? Especially qubes-core-dom0 4.0.18 and qubes-core-admin-client >= 4.0.13

@mirrorway

This comment has been minimized.

Show comment
Hide comment
@mirrorway

mirrorway Jan 19, 2018

yes to both

yes to both

@mirrorway

This comment has been minimized.

Show comment
Hide comment
@mirrorway

mirrorway Jan 19, 2018

qubes-prefs default_dispvm was set to: D None,
after setting it to some VM I can now open vm-settings again.
I don't know why it was None, Maybe because I uninstalled fedora-25 template and installed fedora-26.template.

mirrorway commented Jan 19, 2018

qubes-prefs default_dispvm was set to: D None,
after setting it to some VM I can now open vm-settings again.
I don't know why it was None, Maybe because I uninstalled fedora-25 template and installed fedora-26.template.

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jan 19, 2018

app: define values for default_dispvm=None, updatevm=None
If those VMs are not set, default to None, instead of throwing
AttributeError.

Fixes QubesOS/qubes-issues#3475
@molnara

This comment has been minimized.

Show comment
Hide comment
@molnara

molnara Jan 19, 2018

I just pulled down latest changes and I can confirm I now can edit VM Settings in and open Create Qubes VM.

Updates applied:
qubes-core-dom0 4.0.18
qubes-dbus 1.0.4
qubes-desktop-linux-manager 4.0.6
qubes-manager 4.0.11
qubes-usb-proxy-dom0 1.0.14

Much appreciated all! Thank you.

molnara commented Jan 19, 2018

I just pulled down latest changes and I can confirm I now can edit VM Settings in and open Create Qubes VM.

Updates applied:
qubes-core-dom0 4.0.18
qubes-dbus 1.0.4
qubes-desktop-linux-manager 4.0.6
qubes-manager 4.0.11
qubes-usb-proxy-dom0 1.0.14

Much appreciated all! Thank you.

@marmarek marmarek closed this Jan 19, 2018

@tlaurion

This comment has been minimized.

Show comment
Hide comment
@tlaurion

tlaurion Jan 22, 2018

Contributor

Still have this bug with all updates installed.

Contributor

tlaurion commented Jan 22, 2018

Still have this bug with all updates installed.

@tlaurion

This comment has been minimized.

Show comment
Hide comment
@tlaurion

tlaurion Jan 22, 2018

Contributor

Even if i loop through all qvm-ls and set default_dispvm property to whonix-ws-dvm or -D, the result is still "AttributeError: default_dispvm has no default at line 9 of /usr/bin/qubes-vm-settings"

Contributor

tlaurion commented Jan 22, 2018

Even if i loop through all qvm-ls and set default_dispvm property to whonix-ws-dvm or -D, the result is still "AttributeError: default_dispvm has no default at line 9 of /usr/bin/qubes-vm-settings"

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 22, 2018

Member

Try setting global property default_dispvm:

qubes-prefs default_dispvm whonix-ws-dvm

(or other value)

Member

marmarek commented Jan 22, 2018

Try setting global property default_dispvm:

qubes-prefs default_dispvm whonix-ws-dvm

(or other value)

@tlaurion

This comment has been minimized.

Show comment
Hide comment
@tlaurion

tlaurion Jan 22, 2018

Contributor

Seems like I may not understand global/local usage with qvm-prefs. From my understanding qvm-prefs needs a domain as a first argument, which is how I always used qvm-prefs for.
qvm-prefs default_dispvm whonix-ws-dvm

qvm-prefs: error: no such domain: default_dispvm

Contributor

tlaurion commented Jan 22, 2018

Seems like I may not understand global/local usage with qvm-prefs. From my understanding qvm-prefs needs a domain as a first argument, which is how I always used qvm-prefs for.
qvm-prefs default_dispvm whonix-ws-dvm

qvm-prefs: error: no such domain: default_dispvm

@tlaurion

This comment has been minimized.

Show comment
Hide comment
@tlaurion

tlaurion Jan 22, 2018

Contributor

qvm-ls|awk -F " "  {'print $1'}|while read vm; do qvm-prefs $vm default_dispvm -D; done

qvm-ls|awk -F " " {'print $1'}|grep -v whonix| while read vm; do qvm-prefs $vm default_dispvm whonix-ws-dvm; done

I get the same error.

Contributor

tlaurion commented Jan 22, 2018

qvm-ls|awk -F " "  {'print $1'}|while read vm; do qvm-prefs $vm default_dispvm -D; done

qvm-ls|awk -F " " {'print $1'}|grep -v whonix| while read vm; do qvm-prefs $vm default_dispvm whonix-ws-dvm; done

I get the same error.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 22, 2018

Member

qubes-prefs - global properties
qvm-prefs - per-VM properties

Member

marmarek commented Jan 22, 2018

qubes-prefs - global properties
qvm-prefs - per-VM properties

@tlaurion

This comment has been minimized.

Show comment
Hide comment
@tlaurion

tlaurion Jan 22, 2018

Contributor

Oupsies. My bad. confused qvm-prefs with qubes-prefs.

Calling qubes-prefs default_dispvm whonix-ws-dvm resolved the issue.

I confirm that just upgrading packages creates the issue. Maybe that invocation should be done in a update script to set default to what was created at install (fedora-25-dvm/ whonix-ws-dvm)?

Thanks @marmarek .

Contributor

tlaurion commented Jan 22, 2018

Oupsies. My bad. confused qvm-prefs with qubes-prefs.

Calling qubes-prefs default_dispvm whonix-ws-dvm resolved the issue.

I confirm that just upgrading packages creates the issue. Maybe that invocation should be done in a update script to set default to what was created at install (fedora-25-dvm/ whonix-ws-dvm)?

Thanks @marmarek .

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 23, 2018

Automated announcement from builder-github

The package qubes-core-dom0-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jan 23, 2018

Closed

core-admin v4.0.19 (r4.0) #380

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 6, 2018

Automated announcement from builder-github

The package qubes-manager-4.0.13-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-4.0.13-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 6, 2018

Automated announcement from builder-github

The package qubes-core-dom0-4.0.21-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.21-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment