Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWireless broke again (R4-rc3 following current-testing) #3486
Comments
andrewdavidwong
added
bug
C: core
labels
Jan 22, 2018
andrewdavidwong
added this to the Release 4.0 milestone
Jan 22, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mirrorway
Jan 22, 2018
I have a similar issue in 4.0rc2 tracking current-testing, but atheros wifi (so usually no blacklisting needed).
sys-net hangs on resume.
Short-term workaround: restart sys-net.
Long-term workaround: downgrade sys-net kernel from 4.14.13 to 4.9.56,
mirrorway
commented
Jan 22, 2018
•
|
I have a similar issue in 4.0rc2 tracking current-testing, but atheros wifi (so usually no blacklisting needed). sys-net hangs on resume. Short-term workaround: restart sys-net. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Jan 22, 2018
Member
Does it work if you unload the module manually before the suspend? Do you see any errors in dom0 journalctl, especially related to qubesd or qubes-suspend services?
|
Does it work if you unload the module manually before the suspend? Do you see any errors in dom0 journalctl, especially related to qubesd or qubes-suspend services? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ok, I can reproduce the problem. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Jan 22, 2018
Member
For me, detaching drivers from all PCI devices (besides those qemu emulated) fixes the problem.
I'll patch the script to do that automatically, as it looks like most hardware/drivers require it. Lets not force each user to list drivers manually...
|
For me, detaching drivers from all PCI devices (besides those qemu emulated) fixes the problem. |
marmarek
closed this
in
marmarek/qubes-core-agent-linux@ee122ee
Jan 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-centos7-cur-test
label
Jan 23, 2018
qubesos-bot
referenced this issue
in QubesOS/updates-status
Jan 23, 2018
Closed
core-agent-linux v4.0.18 (r4.0) #381
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package qubes-core-agent_4.0.18-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-jessie-cur-test
label
Jan 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package qubes-core-agent_4.0.18-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-stretch-cur-test
label
Jan 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package python2-dnf-plugins-qubes-hooks-4.0.18-1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-fc24-cur-test
label
Jan 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package python2-dnf-plugins-qubes-hooks-4.0.18-1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-fc25-cur-test
label
Jan 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 23, 2018
Automated announcement from builder-github
The package python2-dnf-plugins-qubes-hooks-4.0.18-1.fc26 has been pushed to the r4.0 testing repository for the Fedora fc26 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
Jan 23, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-fc26-cur-test
label
Jan 23, 2018
awokd
referenced this issue
in QubesOS/qubes-doc
Feb 2, 2018
Closed
linux-hvm-tips mention suspend-module-blacklist #549
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hyperfekt
Feb 3, 2018
Am I correct in the assumption that this should be fixed with qubes-core-agent 4.0.20?
Asking because I have that installed, but still have the exact same problem (same hardware).
Could you confirm, @jpouellet ?
PS: versions:
[user@unknownb88a60933807 ~]$ dnf list installed "qubes-core-agent*"
Installed Packages
qubes-core-agent.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-dom0-updates.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-nautilus.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-network-manager.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-networking.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-passwordless-root.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-qrexec.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
qubes-core-agent-systemd.x86_64 4.0.20-1.fc26 @qubes-builder-vm-r4.0-current-testing
hyperfekt
commented
Feb 3, 2018
•
|
Am I correct in the assumption that this should be fixed with qubes-core-agent 4.0.20? PS: versions:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 3, 2018
Member
Am I correct in the assumption that this should be fixed with qubes-core-agent 4.0.20?
Asking because I have that installed, but still have the exact same problem (same hardware).
Looks like core-agent-linux v4.0.18 was intended to fix this (QubesOS/updates-status#381). Reopening.
Looks like |
andrewdavidwong
reopened this
Feb 3, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 3, 2018
Member
Check with updated VM kernel (kernel-qubes-vm package in dom0, version 4.14.13-3).
|
Check with updated VM kernel (kernel-qubes-vm package in dom0, version 4.14.13-3). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hyperfekt
Feb 3, 2018
I figured it out: Apparently, having iwlmvm and iwlwifi in the suspend-modules-blacklist is the problem. Without them (and a sys-net reboot), everything works fine. The upgrade instructions could note not to add those for R4, just in case people think it's still necessary.
hyperfekt
commented
Feb 3, 2018
•
|
I figured it out: Apparently, having |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 4, 2018
Member
I figured it out: Apparently, having
iwlmvmandiwlwifiin thesuspend-modules-blacklistis the problem. Without them (and a sys-net reboot), everything works fine. The upgrade instructions could note not to add those for R4, just in case people think it's still necessary.
I thought it was still necessary, though. See: QubesOS/qubes-doc#549.
I thought it was still necessary, though. See: QubesOS/qubes-doc#549. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hyperfekt
Feb 4, 2018
I thought with QubesOS/qubes-core-agent-linux@cfbc953 that was solved - at least for me it is.
hyperfekt
commented
Feb 4, 2018
|
I thought with QubesOS/qubes-core-agent-linux@cfbc953 that was solved - at least for me it is. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 4, 2018
Member
I thought with QubesOS/qubes-core-agent-linux@cfbc953 that was solved - at least for me it is.
Wait, don't you mean the opposite? Above, you wrote:
I figured it out: Apparently, having
iwlmvmandiwlwifiin thesuspend-modules-blacklistis the problem. Without them (and a sys-net reboot), everything works fine.
But QubesOS/qubes-core-agent-linux@cfbc953 adds iwlmvm and iwlwifi to the suspend-modules-blacklist. If that commit adds them, which breaks things for you, and you have to remove them in order to fix things, then why does that commit solve anything for you?
Wait, don't you mean the opposite? Above, you wrote:
But QubesOS/qubes-core-agent-linux@cfbc953 adds |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hyperfekt
Feb 5, 2018
I am not really an expert on how this works.
I know the following things, however:
With 3.2, I needed to add these modules keep the WiFi functioning after suspend.
With qubes-core-agent 4.0.20, adding these modules will hang sys-net after suspend. Not adding these still leaves WiFi after suspend functioning.
I know these files are not identical, since looking at it iwldvm is not contained (mind that the commit adds iwldvm instead of iwlwifi!).
I have 2 hypotheses, if you ask me:
- The file in
/rw/configand the one they are added to in the agent are in some kind of conflict. - Having
iwlwifiin there is the culprit and only causes an issue with R4.0.
hyperfekt
commented
Feb 5, 2018
|
I am not really an expert on how this works.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 5, 2018
Member
I know these files are not identical, since looking at it
iwldvmis not contained (mind that the commit addsiwldvminstead ofiwlwifi!).
You're right; I missed that!
Having
iwlwifiin there is the culprit and only causes an issue with R4.0.
In light of the above, this hypothesis makes sense to me now. I'm not an expert either. Perhaps @marmarek can clear things up?
You're right; I missed that!
In light of the above, this hypothesis makes sense to me now. I'm not an expert either. Perhaps @marmarek can clear things up? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 5, 2018
Member
Unloading iwldvm and iwlmvm using modprobe -r (instead of rmmod) also unloads iwlwifi. But maybe if iwldvm is listed twice it cause some problems. Try to launch a terminal in sys-net (or even better: use sudo xl console -t pv sys-net for that) and execute journalctl -f there before suspending the system. This way, even if sys-net will hang, you'll see log entries, especially if that script fails in any way.
|
Unloading |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hyperfekt
Feb 5, 2018
The issue quite clearly is having iwlmvm in /rw/config/suspend-modules-blacklist, iwlwifi or iwldvm causes no issues.
Here is the log of sys-net suspend, I don't trust myself picking just the relevant parts out.
(Although I'm not entirely sure how important chasing this down is, considering it shouldn't be happening anymore anyhow.)
hyperfekt
commented
Feb 5, 2018
•
|
The issue quite clearly is having |
qubesos-bot
added
r4.0-jessie-stable
and removed
r4.0-jessie-cur-test
labels
Feb 6, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Feb 6, 2018
Automated announcement from builder-github
The package qubes-core-agent_4.0.20-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
Feb 6, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-stretch-stable
and removed
r4.0-stretch-cur-test
labels
Feb 6, 2018
qubesos-bot
added
r4.0-fc24-stable
r4.0-fc25-stable
and removed
r4.0-fc24-cur-test
r4.0-fc25-cur-test
labels
Feb 6, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Feb 6, 2018
Automated announcement from builder-github
The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.20-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
Feb 6, 2018
|
Automated announcement from builder-github The component
|
qubesos-bot
added
r4.0-fc26-stable
and removed
r4.0-fc26-cur-test
labels
Feb 6, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Feb 6, 2018
Automated announcement from builder-github
The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
Feb 6, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
r4.0-centos7-stable
and removed
r4.0-centos7-cur-test
labels
Feb 6, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 6, 2018
Member
One more thing: apparently there is a problem with HVM suspend using kernel >= 4.11. This should be fixed in 4.14.13-3, so make sure it is set for sys-net and sys-usb. It should be the default one, if you install updates.
|
One more thing: apparently there is a problem with HVM suspend using kernel >= 4.11. This should be fixed in 4.14.13-3, so make sure it is set for sys-net and sys-usb. It should be the default one, if you install updates. |
jpouellet commentedJan 22, 2018
Qubes OS version:
R4-rc3 following current-testing
Affected TemplateVMs:
Clean clone of fedora-26 with nothing additional added, and all updates from default-enabled repos applied.
Steps to reproduce the behavior:
With my hardware:
And this running in dom0 (latest from dom0-current-testing):
and sys-net with:
Expected behavior:
sys-net to come back on resume and wireless to "just work".
Wireless came back up on suspend/resume ~100% of the time before whatever update just broke it.
Actual behavior:
sys-net hangs reliably after every resume
General notes:
I have also always had (and needed):
for the interface to come back up reliably, but the whole VM has not hung before, I just got the exact failure mode described in https://www.qubes-os.org/doc/wireless-troubleshooting/ (which I wrote)