New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backup restore and verification to check whether VM data is missing #3498

Open
andrewdavidwong opened this Issue Jan 27, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@andrewdavidwong
Member

andrewdavidwong commented Jan 27, 2018

In #3467 (comment), @marmarek wrote:

BTW currently verify-only (and actual restore) do not notice if some VM data is completely missing in the archive. Only corrupted data is detected.

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Mar 29, 2018

@marmarek - I'd like to know if you consider this a dom0-only issue?

Currently restore will cycle through all VMs contained in an archive by default, and I think that if any chunk from a VM is missing then the encryption and/or compression layers will report an error. Even the inner tar command should report an error on its own if something is structurally missing (although its other layers that validate data).

dom0 is currently the only VM where the inner tar isn't checked during --verify-only. On R4.0 it still has to successfully decrypt, however.

tasket commented Mar 29, 2018

@marmarek - I'd like to know if you consider this a dom0-only issue?

Currently restore will cycle through all VMs contained in an archive by default, and I think that if any chunk from a VM is missing then the encryption and/or compression layers will report an error. Even the inner tar command should report an error on its own if something is structurally missing (although its other layers that validate data).

dom0 is currently the only VM where the inner tar isn't checked during --verify-only. On R4.0 it still has to successfully decrypt, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment