/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind-dirs.sh silently fails if any of the config dirs are empty #3552

Closed
lvh opened this Issue Feb 7, 2018 · 15 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
5 participants
@lvh @adrelanos @rustybird @qubesos-bot @andrewdavidwong
@lvh

lvh commented Feb 7, 2018 •
edited
Edited 1 time
  • @lvh lvh edited Feb 8, 2018 (most recent)

Qubes OS version:

Any, though observed on 4.0RC4

Affected TemplateVMs:

Any, though observed on fedora-26

Steps to reproduce the behavior:

  • Create e.g. /rw/config/qubes-bind-dirs.d/ in the template based VM and also put a real config file in /etc/qubes-bind.dirs.d/ in the template
  • Reboot VM or unmount & remount bind dirs
  • Bind mount in /etc/ doesn't work (silently on reboot)

Expected behavior:

/etc/ specified bind mount is mounted

Actual behavior:

/etc/ specified bind mount is not mounted

General notes:

The bind-dirs.sh script checks if the different config directories exist with -d, but not if they're empty. Perhaps the easiest way to fix this is to use find to find all the config files?
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Feb 8, 2018

Member

It's using shopt -s nullglob. So an empty config folder shouldn't matter.

We need to know the exact error message why it is failing. What is the output of...?

sudo systemctl --no-pager status qubes-mount-dirs.service
Member

adrelanos commented Feb 8, 2018

It's using shopt -s nullglob. So an empty config folder shouldn't matter.

We need to know the exact error message why it is failing. What is the output of...?

sudo systemctl --no-pager status qubes-mount-dirs.service

@andrewdavidwong andrewdavidwong added bug C: core labels Feb 8, 2018

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Feb 8, 2018

rustybird added a commit to rustybird/qubes-core-agent-linux that referenced this issue Feb 8, 2018

@rustybird
bind-dirs.sh: don't fail on empty configuration directory 
nullglob must be active before a glob is used on a potentially empty
directory. Call shopt immediately after the shebang line.

Fixes QubesOS/qubes-issues#3552
Verified
This commit was signed with a verified signature.
@rustybird rustybird Rusty Bird
GPG key ID: 469D78F47AAF2ADF Learn about signing commits
744cab8

@rustybird rustybird referenced this issue in QubesOS/qubes-core-agent-linux Feb 8, 2018

Merged

bind-dirs.sh: don't fail on empty configuration directory #91

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Feb 8, 2018

The glob was evaluated before shopt -s nullglob - QubesOS/qubes-core-agent-linux#91

rustybird commented Feb 8, 2018

The glob was evaluated before shopt -s nullglob - QubesOS/qubes-core-agent-linux#91

@marmarek marmarek closed this in QubesOS/qubes-core-agent-linux#91 Feb 13, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 13, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.21-1+deb10u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Feb 13, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.21-1+deb10u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-buster-cur-test label Feb 13, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Feb 13, 2018

Closed

core-agent-linux v4.0.21 (r4.0) #410

@qubesos-bot qubesos-bot added the r4.0-jessie-cur-test label Feb 13, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 13, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.21-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Feb 13, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.21-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-stretch-cur-test r4.0-fc24-cur-test r4.0-fc25-cur-test labels Feb 13, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 13, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.21-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Feb 13, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.21-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-fc26-cur-test label Feb 13, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 13, 2018

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

qubesos-bot commented Feb 13, 2018

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-centos7-cur-test label Feb 13, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 12, 2018

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Mar 12, 2018

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-centos7-stable and removed r4.0-centos7-cur-test labels Mar 12, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 12, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.24-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Mar 12, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.24-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-fc26-stable and removed r4.0-fc26-cur-test labels Mar 12, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 12, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.24-1+deb10u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Mar 12, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.24-1+deb10u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-buster-stable r4.0-jessie-stable and removed r4.0-buster-cur-test r4.0-jessie-cur-test labels Mar 12, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 12, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.24-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Mar 12, 2018

Automated announcement from builder-github

The package qubes-core-agent_4.0.24-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-stretch-stable and removed r4.0-stretch-cur-test labels Mar 12, 2018

marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Mar 21, 2018

@rustybird @marmarek
bind-dirs.sh: don't fail on empty configuration directory 
nullglob must be active before a glob is used on a potentially empty
directory. Call shopt immediately after the shebang line.

Fixes QubesOS/qubes-issues#3552

(cherry picked from commit 744cab8)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
ac3c8a7
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 22, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.27-1+deb10u1 has been pushed to the r3.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Mar 22, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.27-1+deb10u1 has been pushed to the r3.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r3.2-buster-cur-test label Mar 22, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Mar 22, 2018

Closed

core-agent-linux v3.2.27 (r3.2) #463

@qubesos-bot qubesos-bot added the r3.2-jessie-cur-test label Mar 22, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 22, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.27-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Mar 22, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.27-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-stretch-cur-test r3.2-fc25-cur-test labels Mar 22, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Mar 22, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-3.2.27-1.fc26) has been pushed to the r3.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

qubesos-bot commented Mar 22, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-3.2.27-1.fc26) has been pushed to the r3.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r3.2-fc26-cur-test label Mar 22, 2018

@qubesos-bot qubesos-bot added r3.2-buster-stable r3.2-jessie-stable and removed r3.2-buster-cur-test r3.2-jessie-cur-test labels Apr 18, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Apr 18, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.28-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Apr 18, 2018

Automated announcement from builder-github

The package qubes-core-agent_3.2.28-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-stretch-stable r3.2-fc25-stable and removed r3.2-stretch-cur-test r3.2-fc25-cur-test labels Apr 18, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Apr 18, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-3.2.28-1.fc26) has been pushed to the r3.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Apr 18, 2018

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-3.2.28-1.fc26) has been pushed to the r3.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-fc26-stable and removed r3.2-fc26-cur-test labels Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment