No VM shutdown notifications

[marmarta]

Qubes OS version: R4.0rc4

If a VM is halted from inside (e.g., a template after updates), no notification at all is emitted. If

Steps to reproduce the behavior:

Shutdown a VM.

Expected behavior:

Two notifications are emitted: one when shutdown process begins ([VM] is halting) and one when it's complete ([VM] is halted)

Actual behavior:

If the VM is shut down from inside (e.g., after a template VM update completes), no notification at all is emitted.
If the VM is shut down from manager or the qui-domains tool, only the [VM] is halting notification appears, and nothing about how shutdown was completed.

[donob4n]

The event is received but the callback doesn't send a notification.

/qui/models/domains/domains.py (255):

        self.signal_callbacks = {
            'Starting': self.update_domain_item,
            'Started': self.update_domain_item,
            'Failed': self.update_domain_item,
            'Halting': self.update_domain_item,
            'Halted': self.remove_menu,
            'Unknown': self.update_domain_item,
        }

    def remove_menu(self, _, vm_path):
        ''' Remove the menu item for the specified domain from the tray'''
        vm_widget = self.menu_items[vm_path]
        self.tray_menu.remove(vm_widget)
        del self.menu_items[vm_path]
        self.tray_menu.queue_draw()
        

I would do a pull request but I can't find the repository.

[donob4n]

The event is received but the callback doesn't send a notification.

/qui/models/domains/domains.py (255):

        self.signal_callbacks = {
            'Starting': self.update_domain_item,
            'Started': self.update_domain_item,
            'Failed': self.update_domain_item,
            'Halting': self.update_domain_item,
            'Halted': self.remove_menu,
            'Unknown': self.update_domain_item,
        }

    def remove_menu(self, _, vm_path):
        ''' Remove the menu item for the specified domain from the tray'''
        vm_widget = self.menu_items[vm_path]
        self.tray_menu.remove(vm_widget)
        del self.menu_items[vm_path]
        self.tray_menu.queue_draw()
        

I would do a pull request but I can't find the repository.

[marmarek]

desktop-linux-manager

[marmarek]

desktop-linux-manager

[donob4n]

Done.

Should the subprocess.call() be replaced by direct dbus events?

[donob4n]

Done.

Should the subprocess.call() be replaced by direct dbus events?

[marmarek]

On Thu, May 10, 2018 at 04:40:32AM -0700, donob4n wrote: Done.

Thanks!

Should the subprocess.call() be replaced by direct dbus events?

Yes.

[marmarek]

On Thu, May 10, 2018 at 04:40:32AM -0700, donob4n wrote: Done.

Thanks!

Should the subprocess.call() be replaced by direct dbus events?

Yes.