New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubes Global Settings crash when updating default netVM #3567

Open
micahflee opened this Issue Feb 10, 2018 · 12 comments

Comments

Projects
None yet
5 participants
@micahflee

Qubes OS version:

R4.0

Steps to reproduce the behavior:

Open the Qubes Global Settings program, change the default netVM to something else, and click OK.

Expected behavior:

It should save and update the default netVM.

Actual behavior:

Crash, and the default netVM doesn't get updated.

screenshot_2018-02-10_14-58-17

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n Feb 11, 2018

It seems that your 'sys-vpn-mullvad' netVM is set to default netVM so changing the default netVM is causing a loop. Try setting it to sys-net or sys-firewall before editing default netVM.

donob4n commented Feb 11, 2018

It seems that your 'sys-vpn-mullvad' netVM is set to default netVM so changing the default netVM is causing a loop. Try setting it to sys-net or sys-firewall before editing default netVM.

@micahflee

This comment has been minimized.

Show comment
Hide comment
@micahflee

micahflee Feb 12, 2018

When I open Qubes Global Settings the UI says my default netVM is sys-firewall. I can change it to sys-net and save, and that works fine. When I open it again, the UI says it's sys-net. But if I then change it to sys-vpn-mullvad, I get the same crash. But I can successfully change it back to sys-firewall -- so apparently it's just changing it to my custom proxyVM that's causes it.

After trying (and failing) to set it to sys-vpn-mullvad, when I open fedora-26 dispVM its netVM is sys-firewall, so apparently it's not actually set.

What are the terminal commands for adjusting the global settings?

When I open Qubes Global Settings the UI says my default netVM is sys-firewall. I can change it to sys-net and save, and that works fine. When I open it again, the UI says it's sys-net. But if I then change it to sys-vpn-mullvad, I get the same crash. But I can successfully change it back to sys-firewall -- so apparently it's just changing it to my custom proxyVM that's causes it.

After trying (and failing) to set it to sys-vpn-mullvad, when I open fedora-26 dispVM its netVM is sys-firewall, so apparently it's not actually set.

What are the terminal commands for adjusting the global settings?

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n Feb 12, 2018

@micahflee I meant to change sys-vpn-mullvad to sys-net or sys-firewall before changing the default netVM, have you tried?

donob4n commented Feb 12, 2018

@micahflee I meant to change sys-vpn-mullvad to sys-net or sys-firewall before changing the default netVM, have you tried?

@micahflee

This comment has been minimized.

Show comment
Hide comment
@micahflee

micahflee Feb 12, 2018

I'm not sure what you mean. In Qubes Global Settings I can change the default netVM to either sys-net or sys-firewall, and saving works fine. If I try changing it to sys-vpn-mullvad, I get that crash (no matter what it was before). And sys-vpn-mullvad's netVM is sys-firewall.

I'm not sure what you mean. In Qubes Global Settings I can change the default netVM to either sys-net or sys-firewall, and saving works fine. If I try changing it to sys-vpn-mullvad, I get that crash (no matter what it was before). And sys-vpn-mullvad's netVM is sys-firewall.

@micahflee

This comment has been minimized.

Show comment
Hide comment
@micahflee

micahflee Feb 12, 2018

I've also reproduced this problem on two separate computers with different hardware running Qubes 4.0.

I've also reproduced this problem on two separate computers with different hardware running Qubes 4.0.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 12, 2018

Member

Make sure sys-vpn-mullvad's netvm is set to "sys-firewall", not "default (sys-firewall)".

Member

marmarek commented Feb 12, 2018

Make sure sys-vpn-mullvad's netvm is set to "sys-firewall", not "default (sys-firewall)".

@micahflee

This comment has been minimized.

Show comment
Hide comment
@micahflee

micahflee Feb 12, 2018

Excellent, that fixed it.

Maybe this step could be automatic, because it's not immediately intuitive that there's a difference between "default (sys-firewall)" and "sys-firewall".

Excellent, that fixed it.

Maybe this step could be automatic, because it's not immediately intuitive that there's a difference between "default (sys-firewall)" and "sys-firewall".

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 12, 2018

Member

Maybe some tooltip/help text there? @marmarta @andrewdavidwong

Member

marmarek commented Feb 12, 2018

Maybe some tooltip/help text there? @marmarta @andrewdavidwong

@micahflee

This comment has been minimized.

Show comment
Hide comment
@micahflee

micahflee Feb 12, 2018

Or maybe Qubes Global Settings can catch this error and display some sort of instructions if a user hits it.

Or maybe Qubes Global Settings can catch this error and display some sort of instructions if a user hits it.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Feb 13, 2018

Member

Maybe some tooltip/help text there?

Sounds like a great candidate for #2211.

Perhaps something like:

"default (<vm-name>) denotes the NetVM currently set as the system-wide default. If you change the system-wide default to a different NetVM, then any VM currently set to use default (<vm-name>) will use the new NetVM. If you want a VM to keep using the currently displayed <vm-name> even if the system-wide default changes, select <vm-name> (without the word default in front of it) directly from the list."

This could be clearer, but it's a start.

Member

andrewdavidwong commented Feb 13, 2018

Maybe some tooltip/help text there?

Sounds like a great candidate for #2211.

Perhaps something like:

"default (<vm-name>) denotes the NetVM currently set as the system-wide default. If you change the system-wide default to a different NetVM, then any VM currently set to use default (<vm-name>) will use the new NetVM. If you want a VM to keep using the currently displayed <vm-name> even if the system-wide default changes, select <vm-name> (without the word default in front of it) directly from the list."

This could be clearer, but it's a start.

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n Feb 13, 2018

What do you think about changing the behavior of 'default netVM'? I think that it would be better to use it only for 'default netVM' selection when doing new domains.

Currently, apart of problems like this, it has too wide side effects. It's pretty easy to change the NetVM of a domain (or more) that you didn't want to.

donob4n commented Feb 13, 2018

What do you think about changing the behavior of 'default netVM'? I think that it would be better to use it only for 'default netVM' selection when doing new domains.

Currently, apart of problems like this, it has too wide side effects. It's pretty easy to change the NetVM of a domain (or more) that you didn't want to.

marmarta added a commit to marmarta/qubes-manager that referenced this issue Feb 13, 2018

Added tooltip for Networking
Added a tooltip to clarify what default/not default
means when selecting networking.
Proposed tooltip:
"default ([name])" denotes system-wide default - if the default is changed in Global Settings, the networking qube will change.
If you want to keep using a given networking qube regardless of system settings, select "[name]".

references QubesOS/qubes-issues#2211
references QubesOS/qubes-issues#3567

@marmarta marmarta referenced this issue in QubesOS/qubes-manager Feb 13, 2018

Merged

Bunch of UI improvements #68

marmarta added a commit to marmarta/qubes-manager that referenced this issue Feb 13, 2018

Added tooltip for Networking
Added a tooltip to clarify what default/not default
means when selecting networking.
Proposed tooltip:
"default ([name])" denotes system-wide default - if the default is changed in Global Settings, the networking qube will change.
If you want to keep using a given networking qube regardless of system settings, select "[name]".

references QubesOS/qubes-issues#2211
references QubesOS/qubes-issues#3567

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Feb 27, 2018

Closed

manager v4.0.16 (r4.0) #434

@marmarta

This comment has been minimized.

Show comment
Hide comment
@marmarta

marmarta Jul 15, 2018

I don't think this change is a good idea - in practice, this would mean eliminating 'default' as a setting for VM's netVM, because otherwise it would produce inconsistent results ('default' for one VM would mean something different than for another VM). And the possibility of changing netVM for a bunch of VMs like that is - I think - pretty useful. What can be done (and I'll do it in a moment) is making clearer in the Qube Manager (and, hopefully qvm-ls) that a VM has the 'default' netVM set.

I don't think this change is a good idea - in practice, this would mean eliminating 'default' as a setting for VM's netVM, because otherwise it would produce inconsistent results ('default' for one VM would mean something different than for another VM). And the possibility of changing netVM for a bunch of VMs like that is - I think - pretty useful. What can be done (and I'll do it in a moment) is making clearer in the Qube Manager (and, hopefully qvm-ls) that a VM has the 'default' netVM set.

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 15, 2018

Make 'NetVm' column in Qube Manager clearer with regars to defaults
When a VM has netvm set to 'default', now Qube Manager will display
'(default)' in front of the netvm's name.

references QubesOS/qubes-issues#3567

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 16, 2018

Make 'NetVm' column in Qube Manager clearer with regars to defaults
When a VM has netvm set to 'default', now Qube Manager will display
'(default)' in front of the netvm's name.

references QubesOS/qubes-issues#3567

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 18, 2018

Open

manager v4.0.19 (r4.0) #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment