Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upVM firewall: option to 'reject' output packets instead of 'drop' #3607
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 19, 2018
Member
|
output:
I agree. Reject should be preferred over drop. Imo not even an option
needed. Reject should be default. This ticket is about output only.
input:
Drop makes sense to avoid ddos. But this ticket is not about input, so
no need to discuss it here.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
|
marmarek
self-assigned this
Feb 19, 2018
marmarek
added
enhancement
C: core
P: minor
labels
Feb 19, 2018
marmarek
added this to the Release 4.0 milestone
Feb 19, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 27, 2018
Member
I wonder if this should be the only option - i.e. replace the current "drop" rule. Or make it configurable?
|
I wonder if this should be the only option - i.e. replace the current "drop" rule. Or make it configurable? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
DemiMarie
Feb 28, 2018
@marmarek I think it should. It is much more user-friendly and just as secure.
DemiMarie
commented
Feb 28, 2018
|
@marmarek I think it should. It is much more user-friendly and just as secure. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
donob4n
commented
Mar 1, 2018
|
In my opinion only reject would be fine. |
andrewdavidwong
modified the milestones:
Release 4.0,
Release 4.1
Mar 31, 2018
marmarek
closed this
in
QubesOS/qubes-core-agent-linux@a026d04
May 2, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 2, 2018
Automated announcement from builder-github
The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
May 2, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-centos7-cur-test
label
May 2, 2018
qubesos-bot
referenced this issue
in QubesOS/updates-status
May 2, 2018
Closed
core-agent-linux v4.0.27 (r4.0) #496
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 2, 2018
Automated announcement from builder-github
The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.27-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r4.0-current-testing
qubesos-bot
commented
May 2, 2018
|
Automated announcement from builder-github The component
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 2, 2018
Automated announcement from builder-github
The package qubes-core-agent_4.0.27-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
May 2, 2018
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-stretch-cur-test
label
May 2, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 21, 2018
Automated announcement from builder-github
The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.28-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
May 21, 2018
|
Automated announcement from builder-github The component
|
qubesos-bot
removed
the
r4.0-fc26-cur-test
label
May 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 21, 2018
Automated announcement from builder-github
The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:
sudo yum update
qubesos-bot
commented
May 21, 2018
|
Automated announcement from builder-github The package
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
May 21, 2018
Automated announcement from builder-github
The package qubes-core-agent_4.0.28-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
qubesos-bot
commented
May 21, 2018
|
Automated announcement from builder-github The package
|
taradiddles commentedFeb 19, 2018
Qubes OS version:
R4.x
Proposed enhancement
Implement an option to reject a VM's outgoing packets instead of dropping them, for VMs with "whitelist" firewalls (= "limit connections to..." in the gui).
The rationale behind rejecting out packets instead of dropping them is to avoid:
Note: rejecting packets means sending icmp unreachable or tcp reset packets from the FirewallVM back to the originating VM ; I don't see how this would increase the attack surface on the FirewallVM (how would the reject packets be different than - say - fragmentation neeeded packets ?). But this should be given some thoughts if the option is to be implemented.
BTW I tried to implement this 'reject' functionality in the various qubes firewall.py files (admin, tests, ...) but I keep on getting errors so I must be missing something.
Workaround: in the VM's network VM (eg. sys-firewall), insert an nft reject rule at the appropriate position. For instance, add a rule for the VM with ip 10.137.0.7 at handle 22 before the catch-all 'drop' target (the handle number is determined by
nft list table qubes-firewall -a):nft insert rule ip qubes-firewall qbs-10-137-0-7 position 22 reject