Missing icon for Visual Studio Code

[SaswatPadhi]

Qubes OS version:

Qubes release 4.0 (R4.0)

Affected component(s):

Applications Icons in dom0

---

Steps to reproduce the behavior:

1. Install Qubes 4.0~rc4
2. Install VS Code on a Fedora 26 AppVM
3. Sync applications with dom0

Expected behavior:

Appropriate tinted icon for VS Code should be added to the applications menu.

Actual behavior:

A generic icon for the color associated with the AppVM is added to the applications menu.
However, the application link works fine.

General notes:

The icon is located in /usr/share/pixmaps/code.png within the AppVM.

[SaswatPadhi]

It also happens on Xenial-based AppVMs too.

Is there a log for the script that syncs apps with dom0?

[SaswatPadhi]

It also happens on Xenial-based AppVMs too.

Is there a log for the script that syncs apps with dom0?

[marmarek]

Yes, should be in dom0's journalctl.

[marmarek]

Yes, should be in dom0's journalctl.

[SaswatPadhi]

I checked the journalctl. It complains "Image format violation".

The source reveals that this is raised when the image header is cannot be trusted. I am not sure why this is the case though. Everything looks normal on running identify code-insiders.png. I have attached the png file:

SHA256(code-insiders.png) = bedcade2c4d05f4a976f7ae9e85cfe31acabd97f223acf67b9a6c5126382349f

[SaswatPadhi]

I checked the journalctl. It complains "Image format violation".

The source reveals that this is raised when the image header is cannot be trusted. I am not sure why this is the case though. Everything looks normal on running identify code-insiders.png. I have attached the png file:

SHA256(code-insiders.png) = bedcade2c4d05f4a976f7ae9e85cfe31acabd97f223acf67b9a6c5126382349f

[marmarek]

Not sure why exactly you get this error (instead of "Image size constraint violation"), but the icon is 1024x1024, but maximum allowed by that code is 512x512.

[marmarek]

Not sure why exactly you get this error (instead of "Image size constraint violation"), but the icon is 1024x1024, but maximum allowed by that code is 512x512.

[SaswatPadhi]

I see, thanks.

Can we update the code to use 1024 x 1024?
I think VS Code (and several other apps) use 1024 size for very high DPI (retina display like) devices.

[SaswatPadhi]

I see, thanks.

Can we update the code to use 1024 x 1024?
I think VS Code (and several other apps) use 1024 size for very high DPI (retina display like) devices.