New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user statistics graph has offset labels #3841

Closed
mirrorway opened this Issue Apr 22, 2018 · 12 comments

Comments

Projects
None yet
5 participants
@mirrorway

Qubes OS version:

N/A

Affected component(s):

https://www.qubes-os.org/statistics/


Expected behavior:

Labels are aligned with bars.

Actual behavior:

Labels are off by 1.

General notes:

As a result the last bar appears to be associated with a full last month, not the partial current month,
so makes people think Qubes usage fell off a cliff:
https://www.reddit.com/r/Qubes/comments/8ckvt5/why_has_qubes_dropped_down_in_users/


Related issues:

@andrewdavidwong andrewdavidwong added this to the Documentation/website milestone Apr 22, 2018

woju added a commit to woju/qubes-stats that referenced this issue Apr 24, 2018

Fix "month offset by one"
The window is now exactly 37 months (3 years + 1 month), previously was
variable. For a few months from now this will cause a blank space at the
left of the plot, but that will go eventually. This was done because the
present issue was partially caused by related problem and a previous fix,
which is hereby reverted (27478f0).

QubesOS/qubes-issues#3841
@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 24, 2018

Member

This is fixed in generator now and will kick in this night at around 05:15 UTC.

I kept every third label and had the window to be always 3 years, because current issue is caused by the fix to a previous one (#1711 reopen) and any solution without constraining the Y axis would certainly break in the future. There would be several months from now that will feature blank space to the left of the graph that will get pushed out eventually.

This is how it would look like for present data:

image

Member

woju commented Apr 24, 2018

This is fixed in generator now and will kick in this night at around 05:15 UTC.

I kept every third label and had the window to be always 3 years, because current issue is caused by the fix to a previous one (#1711 reopen) and any solution without constraining the Y axis would certainly break in the future. There would be several months from now that will feature blank space to the left of the graph that will get pushed out eventually.

This is how it would look like for present data:

image

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 24, 2018

Member

Well, it looks awful from distance. I'll remove that red and go straight to yellow.

Member

woju commented Apr 24, 2018

Well, it looks awful from distance. I'll remove that red and go straight to yellow.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Apr 24, 2018

Member

Can we simply hide the current month? IMO it would look better.

Member

marmarek commented Apr 24, 2018

Can we simply hide the current month? IMO it would look better.

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 24, 2018

Member

Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.

Member

woju commented Apr 24, 2018

Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 24, 2018

Member

OK, so here is new version, and it's at least readable:

image

Member

woju commented Apr 24, 2018

OK, so here is new version, and it's at least readable:

image

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Apr 24, 2018

Member

Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.

Yes, those are independent issues.

Member

marmarek commented Apr 24, 2018

Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.

Yes, those are independent issues.

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Apr 25, 2018

Member

The fix is now live so closing.

Member

woju commented Apr 25, 2018

The fix is now live so closing.

@woju woju closed this Apr 25, 2018

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Apr 28, 2018

Member

Can we make the chart less ugly? Thank you!

Member

rootkovska commented Apr 28, 2018

Can we make the chart less ugly? Thank you!

@rootkovska rootkovska reopened this Apr 28, 2018

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska May 7, 2018

Member

To elaborate more:

  1. reintroduce gaps between the bars (perhaps without outlines though)
  2. Either change to the more fine-grained pattern for the Tor areas, or -- better yet -- use shading (i.e. darker color). The current, sparse, pattern looks really bad.
Member

rootkovska commented May 7, 2018

To elaborate more:

  1. reintroduce gaps between the bars (perhaps without outlines though)
  2. Either change to the more fine-grained pattern for the Tor areas, or -- better yet -- use shading (i.e. darker color). The current, sparse, pattern looks really bad.
@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju May 9, 2018

Member
  1. The problem with gaps between bars is that they were fine when the bars were widely apart, but after some time passed, they became uneven, which was uglier than with continuous graph. So I'd like to leave it as is.

  2. That's doable, but I'd have to to get those colours from somewhere. Some time ago Brennan got something resembling a colour palette for Qubes (https://www.qubes-os.org/doc/style-guide/#colors) and the colours in the graph are from there for consistency with the rest of the webpage (sans red, because for some reason it doesn't mix with other colours). But this palette lacks different shades for the same hue.
    I can drop the palette and get some other colour set (maybe Tango? we already use it for VM labels).

Member

woju commented May 9, 2018

  1. The problem with gaps between bars is that they were fine when the bars were widely apart, but after some time passed, they became uneven, which was uglier than with continuous graph. So I'd like to leave it as is.

  2. That's doable, but I'd have to to get those colours from somewhere. Some time ago Brennan got something resembling a colour palette for Qubes (https://www.qubes-os.org/doc/style-guide/#colors) and the colours in the graph are from there for consistency with the rest of the webpage (sans red, because for some reason it doesn't mix with other colours). But this palette lacks different shades for the same hue.
    I can drop the palette and get some other colour set (maybe Tango? we already use it for VM labels).

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju May 9, 2018

Member

image

Member

woju commented May 9, 2018

image

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju May 11, 2018

Member

I think actionable points are done. Closing.

Member

woju commented May 11, 2018

I think actionable points are done. Closing.

@woju woju closed this May 11, 2018

woju added a commit to woju/qubes-stats that referenced this issue May 11, 2018

qubesstats/plot: change colours
- use Tango palette
- current months is lighter

QubesOS/qubes-issues#3841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment