Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upuser statistics graph has offset labels #3841
Comments
andrewdavidwong
added
bug
C: website
labels
Apr 22, 2018
andrewdavidwong
added this to the
Documentation/website milestone
Apr 22, 2018
andrewdavidwong
assigned
woju
Apr 22, 2018
andrewdavidwong
added
the
P: major
label
Apr 22, 2018
added a commit
to woju/qubes-stats
that referenced
this issue
Apr 24, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
Apr 24, 2018
Member
This is fixed in generator now and will kick in this night at around 05:15 UTC.
I kept every third label and had the window to be always 3 years, because current issue is caused by the fix to a previous one (#1711 reopen) and any solution without constraining the Y axis would certainly break in the future. There would be several months from now that will feature blank space to the left of the graph that will get pushed out eventually.
This is how it would look like for present data:
|
This is fixed in generator now and will kick in this night at around 05:15 UTC. I kept every third label and had the window to be always 3 years, because current issue is caused by the fix to a previous one (#1711 reopen) and any solution without constraining the Y axis would certainly break in the future. There would be several months from now that will feature blank space to the left of the graph that will get pushed out eventually. This is how it would look like for present data: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
Apr 24, 2018
Member
Well, it looks awful from distance. I'll remove that red and go straight to yellow.
|
Well, it looks awful from distance. I'll remove that red and go straight to yellow. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Can we simply hide the current month? IMO it would look better. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
Apr 24, 2018
Member
Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.
|
Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Apr 24, 2018
Member
Current month is not a problem and I think it was already discussed. The problem is lack of contrast between red and purple.
Yes, those are independent issues.
Yes, those are independent issues. |
andrewdavidwong
referenced this issue
Apr 25, 2018
Closed
(Re)consider hiding current month in Qubes userbase estimate chart (aka "Statistics") #3858
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
The fix is now live so closing. |
woju
closed this
Apr 25, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Can we make the chart less ugly? Thank you! |
rootkovska
reopened this
Apr 28, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rootkovska
May 7, 2018
Member
To elaborate more:
- reintroduce gaps between the bars (perhaps without outlines though)
- Either change to the more fine-grained pattern for the Tor areas, or -- better yet -- use shading (i.e. darker color). The current, sparse, pattern looks really bad.
|
To elaborate more:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
May 9, 2018
Member
-
The problem with gaps between bars is that they were fine when the bars were widely apart, but after some time passed, they became uneven, which was uglier than with continuous graph. So I'd like to leave it as is.
-
That's doable, but I'd have to to get those colours from somewhere. Some time ago Brennan got something resembling a colour palette for Qubes (https://www.qubes-os.org/doc/style-guide/#colors) and the colours in the graph are from there for consistency with the rest of the webpage (sans red, because for some reason it doesn't mix with other colours). But this palette lacks different shades for the same hue.
I can drop the palette and get some other colour set (maybe Tango? we already use it for VM labels).
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I think actionable points are done. Closing. |



mirrorway commentedApr 22, 2018
Qubes OS version:
N/A
Affected component(s):
https://www.qubes-os.org/statistics/
Expected behavior:
Labels are aligned with bars.
Actual behavior:
Labels are off by 1.
General notes:
As a result the last bar appears to be associated with a full last month, not the partial current month,
so makes people think Qubes usage fell off a cliff:
https://www.reddit.com/r/Qubes/comments/8ckvt5/why_has_qubes_dropped_down_in_users/
Related issues: