New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qubes-template-whonix-gw should depend on qubes-core-admin-addon-whonix #3881

Open
adrelanos opened this Issue May 5, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@adrelanos
Member

adrelanos commented May 5, 2018

qubes-template-whonix-gw should depend on qubes-core-admin-addon-whonix?
qubes-template-whonix-ws should depend on qubes-core-admin-addon-whonix?

Where to declare such a dependency?

(T792)


Related:

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 5, 2018

Member

By design template packages should not have any additional dependencies as a way for installing dom0 packages. This is especially relevant in R4.0, where you can install template package in some Mgmt VM (the template will be transferred to dom0 using Admin API automatically, if policy allows).
Such dependency can be added to a package with whonix salt formulas (qubes-mgmt-salt-dom0-virtual-machines). There is no separate package for whonix formulas, but since the common one include whonix, IMO it's ok to carry also whonix-related dependencies.
Alternatively, this could be added to relevant package group, but this could be not picked up during upgrade, so IMO not such a good idea.

Member

marmarek commented May 5, 2018

By design template packages should not have any additional dependencies as a way for installing dom0 packages. This is especially relevant in R4.0, where you can install template package in some Mgmt VM (the template will be transferred to dom0 using Admin API automatically, if policy allows).
Such dependency can be added to a package with whonix salt formulas (qubes-mgmt-salt-dom0-virtual-machines). There is no separate package for whonix formulas, but since the common one include whonix, IMO it's ok to carry also whonix-related dependencies.
Alternatively, this could be added to relevant package group, but this could be not picked up during upgrade, so IMO not such a good idea.

adrelanos added a commit to adrelanos/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue May 5, 2018

@adrelanos adrelanos referenced this issue in QubesOS/qubes-mgmt-salt-dom0-virtual-machines May 5, 2018

Closed

Requires: qubes-core-admin-addon-whonix #8

@adrelanos

This comment has been minimized.

Show comment
Hide comment
Member

adrelanos commented May 5, 2018

adrelanos added a commit to adrelanos/qubes-installer-qubes-os that referenced this issue May 5, 2018

@adrelanos adrelanos referenced this issue in QubesOS/qubes-installer-qubes-os May 5, 2018

Open

qubes-core-admin-addon-whonix #21

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos May 5, 2018

Member

Above is preferred solution.

Also QubesOS/qubes-installer-qubes-os#21. Perhaps good idea to have both in combination?

Member

adrelanos commented May 5, 2018

Above is preferred solution.

Also QubesOS/qubes-installer-qubes-os#21. Perhaps good idea to have both in combination?

@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone May 5, 2018

adrelanos added a commit to adrelanos/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue May 7, 2018

@adrelanos adrelanos referenced this issue in QubesOS/qubes-mgmt-salt-dom0-virtual-machines May 7, 2018

Merged

Requires: qubes-core-admin-addon-whonix #9

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status May 15, 2018

Open

mgmt-salt-dom0-virtual-machines v4.0.12 (r4.0) #543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment