New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of services in Qubes Manager #3891

Closed
qubesissues opened this Issue May 10, 2018 · 8 comments

Comments

Projects
None yet
6 participants
@qubesissues

Qubes OS version:

4.0

Affected component(s):

Qubes Manager


Steps to reproduce the behavior:

Create a new Qube. Go to its details and click "Services"

Expected behavior:

I expect to see network-manager like they talk about here:
https://www.qubes-os.org/doc/vpn/

Actual behavior:

No services are listed. Manually typing network-manager and hitting "enter" makes the Settings window crash. Manually typing network-manager and hitting Plus Sign makes network-manager show up but you can type any word and hit Plus and it will show up so what is really happening?

General notes:


Related issues:

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n May 10, 2018

I think this is wrong for Qubes 4. sys-net and sys-firewall do not have 'network-manager' service.

Did you select 'provides network' when creating the Qube?

donob4n commented May 10, 2018

I think this is wrong for Qubes 4. sys-net and sys-firewall do not have 'network-manager' service.

Did you select 'provides network' when creating the Qube?

marmarta added a commit to marmarta/qubes-manager that referenced this issue May 17, 2018

Fixes unwanted behavior in VM settings
Whenever Enter was pressed, the Settings window
closed and applied changes, which was very unintuitive
especially in case of Services tab.

references QubesOS/qubes-issues#3891

@marmarta marmarta referenced this issue in QubesOS/qubes-manager May 17, 2018

Merged

Fixes unwanted behavior in VM settings #93

@qubesissues

This comment has been minimized.

Show comment
Hide comment
@qubesissues

qubesissues May 25, 2018

Did you select 'provides network' when creating the Qube?

Yes.

sys-net and sys-firewall do not have 'network-manager' service

I was not talking about those?

Did you select 'provides network' when creating the Qube?

Yes.

sys-net and sys-firewall do not have 'network-manager' service

I was not talking about those?

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n May 25, 2018

Well re-reading you,

Manually typing network-manager and hitting Plus Sign makes network-manager show up but you can type any word and hit Plus and it will show up so what is really happening?

You can create custom services with whatever names you want.
https://www.qubes-os.org/doc/qubes-service/

Sorry for the confusion, since sys-net does not have 'network-manager' I thought it no longer exists.

donob4n commented May 25, 2018

Well re-reading you,

Manually typing network-manager and hitting Plus Sign makes network-manager show up but you can type any word and hit Plus and it will show up so what is really happening?

You can create custom services with whatever names you want.
https://www.qubes-os.org/doc/qubes-service/

Sorry for the confusion, since sys-net does not have 'network-manager' I thought it no longer exists.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 25, 2018

Member

No services are listed.

This is correct, you need to add this entry as you described.

Manually typing network-manager and hitting "enter" makes the Settings window crash.

"Enter" here accepts all the settings (as you hit "OK"). This will be fixed in upcoming update - see linked pull request.

Manually typing network-manager and hitting Plus Sign makes network-manager show up

This is how you should add network-manager service there.

but you can type any word and hit Plus and it will show up so what is really happening?

That's correct. You can find a list of services in documentation (3.2, 4.0), but you can also create your own (or install other packages handling other names there) - that's why it's possible to add any entry there.

Member

marmarek commented May 25, 2018

No services are listed.

This is correct, you need to add this entry as you described.

Manually typing network-manager and hitting "enter" makes the Settings window crash.

"Enter" here accepts all the settings (as you hit "OK"). This will be fixed in upcoming update - see linked pull request.

Manually typing network-manager and hitting Plus Sign makes network-manager show up

This is how you should add network-manager service there.

but you can type any word and hit Plus and it will show up so what is really happening?

That's correct. You can find a list of services in documentation (3.2, 4.0), but you can also create your own (or install other packages handling other names there) - that's why it's possible to add any entry there.

@marmarek marmarek closed this May 25, 2018

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 26, 2018

Member

Reopening as a UX enhancement issue.

Manually typing network-manager and hitting Plus Sign makes network-manager show up

This is how you should add network-manager service there.

IMHO, there should be some way to discover available services and select from them instead of having to know the name or look it up from an external source and type it in manually.

but you can type any word and hit Plus and it will show up so what is really happening?

That's correct. You can find a list of services in documentation (3.2, 4.0), but you can also create your own (or install other packages handling other names there) - that's why it's possible to add any entry there.

IMHO, we should distinguish between:

  1. Giving the user the ability to enter arbitrary names of possible services.
  2. Presenting the complete list of arbitrary user inputs as if it were the actual list of services.

1 is fine, but 2 is not. If possible, the system should present the actual list of services. If the list isn't validated, a simple typo would mean that the intended service doesn't get used.

Member

andrewdavidwong commented May 26, 2018

Reopening as a UX enhancement issue.

Manually typing network-manager and hitting Plus Sign makes network-manager show up

This is how you should add network-manager service there.

IMHO, there should be some way to discover available services and select from them instead of having to know the name or look it up from an external source and type it in manually.

but you can type any word and hit Plus and it will show up so what is really happening?

That's correct. You can find a list of services in documentation (3.2, 4.0), but you can also create your own (or install other packages handling other names there) - that's why it's possible to add any entry there.

IMHO, we should distinguish between:

  1. Giving the user the ability to enter arbitrary names of possible services.
  2. Presenting the complete list of arbitrary user inputs as if it were the actual list of services.

1 is fine, but 2 is not. If possible, the system should present the actual list of services. If the list isn't validated, a simple typo would mean that the intended service doesn't get used.

@andrewdavidwong andrewdavidwong added enhancement UX and removed bug labels May 26, 2018

@andrewdavidwong andrewdavidwong changed the title from no services available to new Qube to Improve handling of services in Qubes Manager May 26, 2018

@qubesissues

This comment has been minimized.

Show comment
Hide comment
@qubesissues

qubesissues Jun 19, 2018

IMHO, there should be some way to discover available services and select from them instead of having to know the name or look it up from an external source and type it in manually.

Yes this would solve the Issue.

IMHO, there should be some way to discover available services and select from them instead of having to know the name or look it up from an external source and type it in manually.

Yes this would solve the Issue.

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jun 27, 2018

Closed

manager v4.0.18 (r4.0) #563

@marmarta

This comment has been minimized.

Show comment
Hide comment
@marmarta

marmarta Jul 15, 2018

There is no way to actually list all available services, but perhaps we could show a list of suggestions (as man qvm-services displays).

There is no way to actually list all available services, but perhaps we could show a list of suggestions (as man qvm-services displays).

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 15, 2018

Add a list of Suggested Services to VM settings
Added a list of suggested services to the Services tab in VM Settings.
The list is drawn from man qvm-services (manually, not automatically).

fixes QubesOS/qubes-issues#3891

@marmarta marmarta referenced this issue in QubesOS/qubes-manager Jul 15, 2018

Merged

Add a list of Suggested Services to VM settings #116

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 18, 2018

Automated announcement from builder-github

The package qubes-manager-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 18, 2018

Open

manager v4.0.19 (r4.0) #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment