/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer refers to URL that returns 404 #3932

Closed
Forbo opened this Issue May 26, 2018 · 8 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.1
4 participants
@Forbo @marmarek @andrewdavidwong @qubesos-bot
@Forbo

Forbo commented May 26, 2018 •
edited
Edited 1 time
  • @Forbo Forbo edited May 26, 2018 (most recent)

Qubes OS version:

4.0

Affected component(s):

Installer

Steps to reproduce the behavior:

Attempt to install on hardware where the "Unsupported Hardware Detected" dialog appears. It refers you to https://www.qubes-os.org/system-requirements/ which returns a 404. The actual URL should be https://www.qubes-os.org/doc/system-requirements/

Expected behavior:

Reference https://www.qubes-os.org/doc/system-requirements/ in the error dialog.

Actual behavior:

Refers to https://www.qubes-os.org/system-requirements/ which returns a 404.

General notes:

More of an annoyance than anything, very minor adjustment. Looks like there are two instances of the incorrect URL being used.

Related issues:

N/A?
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 26, 2018

Member

@andrewdavidwong could you add redirection?
Member

marmarek commented May 26, 2018

@andrewdavidwong could you add redirection?
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 26, 2018

Member

Thanks for spotting this!

The URL has been https://www.qubes-os.org/doc/system-requirements/ since 2015-10-28, so someone probably just made a typo when adding it to the "Unsupported Hardware Detected" message.

In the meantime, I'll add a redirect from https://www.qubes-os.org/system-requirements/ to https://www.qubes-os.org/doc/system-requirements/ so that it doesn't 404.
Member

andrewdavidwong commented May 26, 2018

Thanks for spotting this!

The URL has been https://www.qubes-os.org/doc/system-requirements/ since 2015-10-28, so someone probably just made a typo when adding it to the "Unsupported Hardware Detected" message.

In the meantime, I'll add a redirect from https://www.qubes-os.org/system-requirements/ to https://www.qubes-os.org/doc/system-requirements/ so that it doesn't 404.

@andrewdavidwong andrewdavidwong added bug C: installer P: minor labels May 26, 2018

@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone May 26, 2018

@andrewdavidwong andrewdavidwong added task and removed bug labels May 26, 2018

@Forbo

This comment has been minimized.

Show comment
Hide comment
@Forbo

Forbo May 26, 2018

Oh, wow, that was fast! I went in to edit with the two instances I had found and you had already tagged it. ^__^

Forbo commented May 26, 2018 •
edited
Edited 1 time
  • @Forbo Forbo edited May 26, 2018 (most recent)

Oh, wow, that was fast! I went in to edit with the two instances I had found and you had already tagged it. ^__^
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 26, 2018

Member

@Forbo:

Oh, wow, that was fast! I went in to edit with the two instances I had found and you had already tagged and reviewed.

Two instances?
Member

andrewdavidwong commented May 26, 2018

@Forbo:

Oh, wow, that was fast! I went in to edit with the two instances I had found and you had already tagged and reviewed.

Two instances?

andrewdavidwong added a commit to QubesOS/qubes-doc that referenced this issue May 26, 2018

@andrewdavidwong
Add redirect to System Requirements (QubesOS/qubes-issues#3932)
Verified
This commit was signed with a verified signature.
@andrewdavidwong andrewdavidwong Andrew David Wong
GPG key ID: 8CE137352A019A17 Learn about signing commits
Loading status checks…
d239721
@Forbo

This comment has been minimized.

Show comment
Hide comment
@Forbo

Forbo May 26, 2018

Yes, one in warnings_spoke.py and one in welcome.glade. I added links for them in the general notes of the original submission. I just found them when searching the repo for system-requirements, which returned 14 results, only two of which lacked the /doc/ portion of the URL.

Forbo commented May 26, 2018

Yes, one in warnings_spoke.py and one in welcome.glade. I added links for them in the general notes of the original submission. I just found them when searching the repo for system-requirements, which returned 14 results, only two of which lacked the /doc/ portion of the URL.

marmarek added a commit to QubesOS/qubesos.github.io that referenced this issue May 26, 2018

@marmarek
autoupdate: _doc 
_doc:
    gpg: Good signature from "Andrew David Wong (Qubes Documentation Signing Key)" [ultimate]
    object d23972195f739c881fff1864e61374baa0c0443e
    type commit
    tag adw_d2397219
    tagger Andrew David Wong <adw@andrewdavidwong.com> 1527376237 -0500

    Tag for commit d23972195f739c881fff1864e61374baa0c0443e

    d239721 Add redirect to System Requirements (QubesOS/qubes-issues#3932)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: F32894BE9684938A Learn about signing commits
Loading status checks…
1a9e2d5
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 27, 2018

Member

Oh, I see. Thanks!
Member

andrewdavidwong commented May 27, 2018

Oh, I see. Thanks!

@andrewdavidwong andrewdavidwong referenced this issue in QubesOS/qubes-installer-qubes-os May 27, 2018

Merged

Fix System Requirements URL and typo in hardware warnings #23

@marmarek marmarek closed this in marmarek/qubes-installer-qubes-os@f6bfe11 May 28, 2018

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 3, 2018

Automated announcement from builder-github

The package pykickstart-2.32-4.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Jul 3, 2018

Automated announcement from builder-github

The package pykickstart-2.32-4.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Jul 3, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 3, 2018

Closed

installer-qubes-os v25.20.9-13-anaconda (r4.0) #570

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 23, 2018

Automated announcement from builder-github

The package pykickstart-2.32-4.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Jul 23, 2018

Automated announcement from builder-github

The package pykickstart-2.32-4.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-dom0-stable and removed r4.0-dom0-cur-test labels Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment