New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much pulseaudio info/debug log #3933

Closed
donob4n opened this Issue May 27, 2018 · 20 comments

Comments

@donob4n

donob4n commented May 27, 2018

Qubes OS version:

R4

Affected component(s):

journald, disk usage


Steps to reproduce the behavior:

I found this messages on a lot of vm's, even on fedora template:
May 26 21:44:15 media pulseaudio[828]: write_to_vchan: all=3864000 waited=62012 nonwaited=3801988 full=0

May 26 21:44:58 media pulseaudio[828]: write_to_vchan: all=3872000 waited=62058 nonwaited=3809942 full=0

May 26 21:45:42 media pulseaudio[828]: write_to_vchan: all=3880000 waited=62099 nonwaited=3817901 full=0

May 26 21:46:25 media pulseaudio[828]: write_to_vchan: all=3888000 waited=62141 nonwaited=3825859 full=0

Expected behavior:

If this is a useful info or a debug message log it a reasonable rate, else remove it.
If it is a debug info maybe it should only appear with some debug mode enabled.

Actual behavior:

It logs more than one per minute when playing audio.

General notes:

It is logged here https://github.com/QubesOS/qubes-gui-agent-linux/blob/4427218dc382c66a98e22d5e67bdef5a87a5b3ba/pulse/module-vchan-sink.c#L257 .


Related issues:

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 27, 2018

Member

@marmarek added the good first issue label 5 hours ago

But this isn't @donob4n's first issue. 🙂

Member

andrewdavidwong commented May 27, 2018

@marmarek added the good first issue label 5 hours ago

But this isn't @donob4n's first issue. 🙂

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 27, 2018

Member

Possibly related: #830

Member

andrewdavidwong commented May 27, 2018

Possibly related: #830

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 27, 2018

Member

But this isn't @donob4n's first issue.

No, I'm marking low hanging fruits for first time contributors.

Member

marmarek commented May 27, 2018

But this isn't @donob4n's first issue.

No, I'm marking low hanging fruits for first time contributors.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 27, 2018

Member

No, I'm marking low hanging fruits for first time contributors.

Ok, but it makes it sound like someone new to reporting issues did a good job on their first try. Do you mind if I rename the label to clarify?

Member

andrewdavidwong commented May 27, 2018

No, I'm marking low hanging fruits for first time contributors.

Ok, but it makes it sound like someone new to reporting issues did a good job on their first try. Do you mind if I rename the label to clarify?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 27, 2018

Member

Personally I don't mind, but that's one of github default labels.

Member

marmarek commented May 27, 2018

Personally I don't mind, but that's one of github default labels.

@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n May 27, 2018

lol

So is this info useful for something? Better removing it, reducing output rate or doing it optional?

donob4n commented May 27, 2018

lol

So is this info useful for something? Better removing it, reducing output rate or doing it optional?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 27, 2018

Member

@andrewdavidwong Oh, looks like this is not only one of default labels, but also actively promoted by github

@donob4n It's useful for debugging very weird cases we haven't seen for years. Either removing or making it optional is ok.

Member

marmarek commented May 27, 2018

@andrewdavidwong Oh, looks like this is not only one of default labels, but also actively promoted by github

@donob4n It's useful for debugging very weird cases we haven't seen for years. Either removing or making it optional is ok.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 27, 2018

Member

Personally I don't mind, but that's one of github default labels.

@andrewdavidwong Oh, looks like this is not only one of default labels, but also actively promoted by github

Ok, looks like my beef is with GitHub, not with you. 🤣

No problem. We can stick with this label so that people who are familiar with it from other projects will recognize it here.

Member

andrewdavidwong commented May 27, 2018

Personally I don't mind, but that's one of github default labels.

@andrewdavidwong Oh, looks like this is not only one of default labels, but also actively promoted by github

Ok, looks like my beef is with GitHub, not with you. 🤣

No problem. We can stick with this label so that people who are familiar with it from other projects will recognize it here.

@fosslinux

This comment has been minimized.

Show comment
Hide comment
@fosslinux

fosslinux May 28, 2018

I am interested in making a PR for this - should be easy. However, I am worried about the GPG signing. Due to classified reasons, (for now at least) I must keep full anonymity. As a result, I have simply kept my GitHub name as the "Full name" and my GitHub commit email as the "Email address". Is this OK, or is this a problem?

I am interested in making a PR for this - should be easy. However, I am worried about the GPG signing. Due to classified reasons, (for now at least) I must keep full anonymity. As a result, I have simply kept my GitHub name as the "Full name" and my GitHub commit email as the "Email address". Is this OK, or is this a problem?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 28, 2018

Member

I am interested in making a PR for this - should be easy. However, I am worried about the GPG signing. Due to classified reasons, (for now at least) I must keep full anonymity. As a result, I have simply kept my GitHub name as the "Full name" and my GitHub commit email as the "Email address". Is this OK, or is this a problem?

Shouldn't be a problem. We don't require anyone to use their "real" name for anything.

Member

andrewdavidwong commented May 28, 2018

I am interested in making a PR for this - should be easy. However, I am worried about the GPG signing. Due to classified reasons, (for now at least) I must keep full anonymity. As a result, I have simply kept my GitHub name as the "Full name" and my GitHub commit email as the "Email address". Is this OK, or is this a problem?

Shouldn't be a problem. We don't require anyone to use their "real" name for anything.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 28, 2018

Member

As Andrew said, we require to use signatures, but not real names. This is mostly because we don't trust infrastructure, github included. This is one mitigation we take, to not rely on github authentication system too much.

See also here how to keep email private on github.

Member

marmarek commented May 28, 2018

As Andrew said, we require to use signatures, but not real names. This is mostly because we don't trust infrastructure, github included. This is one mitigation we take, to not rely on github authentication system too much.

See also here how to keep email private on github.

@fosslinux

This comment has been minimized.

Show comment
Hide comment
@donob4n

This comment has been minimized.

Show comment
Hide comment
@donob4n

donob4n Jun 6, 2018

If the debug is removed are the vars used for something?
static int all = 0, waited = 0, nonwaited = 0, full = 0;

donob4n commented Jun 6, 2018

If the debug is removed are the vars used for something?
static int all = 0, waited = 0, nonwaited = 0, full = 0;

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 15, 2018

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 15, 2018

Closed

gui-agent-linux v4.0.11 (r4.0) #586

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 15, 2018

Member

static int all = 0, waited = 0, nonwaited = 0, full = 0;

I don't think so.

Member

marmarek commented Jul 15, 2018

static int all = 0, waited = 0, nonwaited = 0, full = 0;

I don't think so.

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 15, 2018

Automated announcement from builder-github

The component gui-agent-linux (including package pulseaudio-qubes-4.0.11-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The component gui-agent-linux (including package pulseaudio-qubes-4.0.11-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 15, 2018

Automated announcement from builder-github

The package qubes-gui-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gui-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

marmarek added a commit to marmarek/qubes-gui-agent-linux that referenced this issue Jul 16, 2018

marmarek added a commit to QubesOS/qubes-gui-agent-linux that referenced this issue Jul 16, 2018

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 16, 2018

Closed

gui-agent-linux v3.2.23 (r3.2) #589

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 23, 2018

Automated announcement from builder-github

The package qubes-gui-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gui-agent_4.0.11-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 23, 2018

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package gui-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 23, 2018

Automated announcement from builder-github

The component gui-agent-linux (including package pulseaudio-qubes-4.0.11-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The component gui-agent-linux (including package pulseaudio-qubes-4.0.11-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment