New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-prefs should accept "none" vm name for netvms #3942

Closed
jaseg opened this Issue May 31, 2018 · 4 comments

Comments

@jaseg

jaseg commented May 31, 2018

Qubes OS version:

4.0

Affected component(s):

qvm-prefs

Steps to reproduce the behavior:

qvm-prefs personal netvm none

Expected behavior:

Netvm set to (none) as would be displayed in the settings GUI, VM networking is disabled.

Actual behavior:

qvm-prefs quits with an error message:
qvm-prefs: error: VM name cannot be 'none' nor 'default'

General notes:

It took me the better part of two weeks running into this issue repeatedly until I bothered to search qubes-issues to discover that somewhere in man qvm-prefs it is mentioned that you set a domain's netvm to none by passing an empty string(!) to qvm-prefs.

IMHO there's two ways to fix this.

  • Make the above error message read qvm-prefs: error: VM name cannot be 'none' nor 'default'. To un-set a VM name, set it to the empty string "".
  • Accept none as a VM name. The user's intent is obvious in this case, and it would be consistent with the settings GUI. Thanks to #3002 and QubesOS/qubes-core-admin#144 there is no harm in doing this.

I would strongly recommend the latter, as that is what I would have expected, and AFAIR this is what qubes R3.2 did. In addition, assigning special semantics to empty-string command line arguments is just gross.

Related issues:

#3287 and #3011 where people shared my confusion on this.
#3002 and QubesOS/qubes-core-admin#144 in which creating VMs named "none" was disallowed.

@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone May 31, 2018

jimtahu added a commit to jimtahu/qubes-core-admin-client that referenced this issue Jun 7, 2018

Change "None" to Property None
This changes to accept the string none as the value None,
as if an empty string was entered. This allows setting the
netvm to "None" as described in QubesOS/qubes-issues#3942

@jimtahu jimtahu referenced this issue in QubesOS/qubes-core-admin-client Jun 7, 2018

Merged

Change qvm_prefs to handle "None" as Property None #68

jimtahu added a commit to jimtahu/qubes-core-admin-client that referenced this issue Jun 8, 2018

Change "None" to Property None
This changes to accept the string none as the value None,
as if an empty string was entered. This allows setting the
netvm to "None" as described in QubesOS/qubes-issues#3942
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jun 27, 2018

Automated announcement from builder-github

The package python2-qubesadmin-4.0.18-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.18-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jun 27, 2018

Closed

core-admin-client v4.0.18 (r4.0) #561

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jun 27, 2018

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jun 27, 2018

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.18-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.18-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jun 27, 2018

Automated announcement from builder-github

The component core-admin-client (including package python2-qubesadmin-4.0.18-0.1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The component core-admin-client (including package python2-qubesadmin-4.0.18-0.1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment