New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distrusting GitHub interface PGP keys interface #3962

Closed
fosslinux opened this Issue Jun 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@fosslinux

A bit of a continuation on #3958, another point I have noted where we don't distrust GitHub's infrastructure, specifically the interface, is PGP keys.

We are trusting GitHub to display the correct PGP key. Other than manual checking, there is no way to confirm that GitHub is displaying the correct PGP key that the commit was signed as. Also, the PGP key shown may not be the same as the key the commit was actually signed with (ie GitHub could change the key signed with).

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jun 6, 2018

Member

A bit of a continuation on #3958, another point I have noted where we don't distrust GitHub's infrastructure, specifically the interface, is PGP keys.

We are trusting GitHub to display the correct PGP key.

This is false. In no way do we (the Qubes team) trust GitHub with respect to PGP keys, signing, or encryption.

Other than manual checking, there is no way to confirm that GitHub is displaying the correct PGP key that the commit was signed as. Also, the PGP key shown may not be the same as the key the commit was actually signed with (ie GitHub could change the key signed with).

Of course we don't use or rely on GitHub's display of PGP keys or signing for anything.

Member

andrewdavidwong commented Jun 6, 2018

A bit of a continuation on #3958, another point I have noted where we don't distrust GitHub's infrastructure, specifically the interface, is PGP keys.

We are trusting GitHub to display the correct PGP key.

This is false. In no way do we (the Qubes team) trust GitHub with respect to PGP keys, signing, or encryption.

Other than manual checking, there is no way to confirm that GitHub is displaying the correct PGP key that the commit was signed as. Also, the PGP key shown may not be the same as the key the commit was actually signed with (ie GitHub could change the key signed with).

Of course we don't use or rely on GitHub's display of PGP keys or signing for anything.

@fosslinux

This comment has been minimized.

Show comment
Hide comment
@fosslinux

fosslinux Jun 6, 2018

fosslinux commented Jun 6, 2018

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jun 7, 2018

Member

I think my post was not 100% clear. In no way did I mean
that the Qubes team trust GitHub. However, I am more concerned about people
who make pull requests, etc and that Qubes contributors using GitHub may
unintentionally trust GitHub
. I would like to emphasize that I was not
talking about the Qubes team.

Basically, to phrase in a different way, is there any way that we can
reduce the trust Qubes contributors may unintentionally put in GitHub?

Ultimately, this requires contributors to understand how PGP works so that they understand how trusting GitHub's representation of a verified signature is different from verifying the PGP signatures on tags and commits oneself on a trusted local machine using properly validated keys. We can aid this understanding by adding an appropriate explanation to our Verifying Signatures page.

Member

andrewdavidwong commented Jun 7, 2018

I think my post was not 100% clear. In no way did I mean
that the Qubes team trust GitHub. However, I am more concerned about people
who make pull requests, etc and that Qubes contributors using GitHub may
unintentionally trust GitHub
. I would like to emphasize that I was not
talking about the Qubes team.

Basically, to phrase in a different way, is there any way that we can
reduce the trust Qubes contributors may unintentionally put in GitHub?

Ultimately, this requires contributors to understand how PGP works so that they understand how trusting GitHub's representation of a verified signature is different from verifying the PGP signatures on tags and commits oneself on a trusted local machine using properly validated keys. We can aid this understanding by adding an appropriate explanation to our Verifying Signatures page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment