New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-start should give a descriptive error message if private missing but tmp still present #3968

Closed
jaseg opened this Issue Jun 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@jaseg

jaseg commented Jun 7, 2018

Qubes OS version:

R4.0

Affected component(s):

qvm-start

Steps to reproduce the behavior:

I can not reproduce the original issue (private-tmp volume not being cleaned up for some reason) but I suppose if you manually rename the private volume you can provoke the unhelpful error message.

Expected behavior:

When private volume is not found, but -tmp clone of private volume is still present, qvm-start should display an error message along the lines of Something bugged out, the vm's private volume is missing but its private-tmp is still there. Consult https://github.com/QubesOS/qubes-issues/issues/3314#issuecomment-345105356 to resolve.

Ideally, qvm-run when called from one of the application menu shortcuts would display an error dialog, too. On my machine, it just failed silently.

Actual behavior:

qvm-start just says something along the lines of "private volume not found". Figuring out what this means and how to fix took a bit of googling.

General notes:

Though the original issue is that private volumes are not cleaned up, I think a more accurate error message would reduce the frequency of heart attacks among qubes users 😉


Related issues:

#3314

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 7, 2018

Member

There is even better thing work in progress - automatically handle this situation (cleanup it).
QubesOS/qubes-core-admin#203 (comment)

Member

marmarek commented Jun 7, 2018

There is even better thing work in progress - automatically handle this situation (cleanup it).
QubesOS/qubes-core-admin#203 (comment)

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jun 8, 2018

Member

Closing as "won't do" since the better solution @marmarek mentioned is already in progress. If anyone has a new argument for why this should be done even though the better solution is already in progress, please leave a comment, and we'll be happy to take another look. Thank you.

Member

andrewdavidwong commented Jun 8, 2018

Closing as "won't do" since the better solution @marmarek mentioned is already in progress. If anyone has a new argument for why this should be done even though the better solution is already in progress, please leave a comment, and we'll be happy to take another look. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment