New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qubes-qrexec-agent startup notification to avoid race conditions #3985

Open
marmarek opened this Issue Jun 13, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Jun 13, 2018

During VM startup, even if service have proper dependency (After=qubes-qrexec-agent.service), it doesn't necessary mean that qrexec agent is indeed ready at that time. Example:

Jun 13 06:52:37 grub-debian systemd[1]: Started Qubes remote exec agent.
Jun 13 06:52:37 grub-debian systemd[1]: Started Qubes GUI Agent.
...
Jun 13 06:52:37 grub-debian qvm-sync-clock[819]: connect: No such file or directory
Jun 13 06:52:37 grub-debian systemd[1]: qubes-sync-time.service: Main process exited, code=exited, status=1/FAILURE
Jun 13 06:52:37 grub-debian systemd[1]: qubes-sync-time.service: Unit entered failed state.
Jun 13 06:52:37 grub-debian systemd[1]: qubes-sync-time.service: Failed with result 'exit-code'.

To solve this, qubes-qrexec-agent service should signal systemd when it's ready, not just when the main process was started.

@marmarek marmarek added this to the Release 4.0 updates milestone Jun 13, 2018

@marmarek marmarek self-assigned this Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment