New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4: Disk password input field crashing when typing special characters #4009

Closed
Ekleog opened this Issue Jun 16, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@Ekleog

Ekleog commented Jun 16, 2018

Qubes OS version:

R4

Affected component(s):

Splash screen for inputting the disk password


Steps to reproduce the behavior:

  1. Have a LUKS password including digits
  2. Input them in the boot-time disk password field via the keypad while forgetting to turn NumLock on

Expected behavior:

~Nothing happens (or ideally NumLock is turned on by default on boot), the password field sees as input the typed characters.

Actual behavior:

The password entry prompt screen crashes during input and falls back to a tty with (IIRC) systemd logs displayed.

General notes:

I unfortunately don't have access to the computer on which this happened, and don't have R4 installed locally, so won't be able to help much in debugging this… sorry!


Related issues:

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 16, 2018

Member

It isn't crashing. Pressing esc, arrows and other such keys switches between verbose and normal view. You can press esc to switch back to normal view. But if you want, you can also enter your password in verbose view.

Member

marmarek commented Jun 16, 2018

It isn't crashing. Pressing esc, arrows and other such keys switches between verbose and normal view. You can press esc to switch back to normal view. But if you want, you can also enter your password in verbose view.

@marmarek marmarek closed this Jun 16, 2018

@Ekleog

This comment has been minimized.

Show comment
Hide comment
@Ekleog

Ekleog Jun 16, 2018

Hmm, from memory there was no input field clearly visible, but I couldn't swear that.

That said, is there a reason why arrows switch to terminal view? (The numpad only has Home, PgUp, End, PgDn, Ins and arrow keys when NumLock is turned off) That's unexpected at best for the non-technical user, who will be freaked out by any terminal (which is exactly the situation I witnessed)

Ekleog commented Jun 16, 2018

Hmm, from memory there was no input field clearly visible, but I couldn't swear that.

That said, is there a reason why arrows switch to terminal view? (The numpad only has Home, PgUp, End, PgDn, Ins and arrow keys when NumLock is turned off) That's unexpected at best for the non-technical user, who will be freaked out by any terminal (which is exactly the situation I witnessed)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 16, 2018

Member

Probably because those keys encoding contains esc char. Ask plymouth (the thing displaying that prompt) authors...

Member

marmarek commented Jun 16, 2018

Probably because those keys encoding contains esc char. Ask plymouth (the thing displaying that prompt) authors...

@Ekleog

This comment has been minimized.

Show comment
Hide comment
@Ekleog

Ekleog Jun 16, 2018

Hmmm that's likely indeed, so that's an upstream bug, will report to plymouth, thanks!

Ekleog commented Jun 16, 2018

Hmmm that's likely indeed, so that's an upstream bug, will report to plymouth, thanks!

@Ekleog

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment