Add option to automatically shutdown netVM of child in qvm-shutdown

[kq4x]

Qubes OS version: R3.2

Affected component(s): qvm-shutdown

Hi there,
I have added a feature to the qvm-shutdown script in R3.2 . What it does is add an option to (recursively) shutdown the parent netVM of the VM. Since the code has changed since R3.2 I cannot add it to the new version.

I could not find the R3.2 branch in https://github.com/QubesOS/qubes-core-admin-client so I thought I'd post here.
The file in question is https://github.com/QubesOS/qubes-core-admin-client/blob/master/qubesadmin/tools/qvm_shutdown.py

I have attached the modified file and the diff compared to the original R3.2 qvm-shutdown file to this issue.
qvm-shutdown.stop-netvm.diff.txt
qvm-shutdown.stop-netvm.txt

[marmarek]

The R3.2 version is here: https://github.com/QubesOS/qubes-core-admin/blob/release3.2/qvm-tools/qvm-shutdown (it was split into qubes-core-admin-client as part of R4.0 rewrite)

[marmarek]

The R3.2 version is here: https://github.com/QubesOS/qubes-core-admin/blob/release3.2/qvm-tools/qvm-shutdown (it was split into qubes-core-admin-client as part of R4.0 rewrite)

[kq4x]

Ok I will make a proper PR

[kq4x]

Ok I will make a proper PR

[andrewdavidwong]

I find the use of "parent" and "child" here confusing. What exactly is the "parent NetVM"? Is that just the VM's NetVM? If so, can we drop the word "parent"? A VM's NetVM is neither its parent nor its child.

[andrewdavidwong]

I find the use of "parent" and "child" here confusing. What exactly is the "parent NetVM"? Is that just the VM's NetVM? If so, can we drop the word "parent"? A VM's NetVM is neither its parent nor its child.