Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate /boot/grub/grub.cfg kernel boot parameters /etc/default/grub #5340

Closed
adrelanos opened this issue Sep 23, 2019 · 1 comment
Closed

Deduplicate /boot/grub/grub.cfg kernel boot parameters /etc/default/grub #5340

adrelanos opened this issue Sep 23, 2019 · 1 comment
Labels
C: other P: minor Priority: minor. The lowest priority, below "default." T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@adrelanos
Copy link
Member

/etc/default/grub contains:

GRUB_CMDLINE_LINUX="root=/dev/mapper/dmroot console=hvc0 console=tty0 swiotlb=8192 root=/dev/mapper/dmroot console=hvc0 console=tty0 swiotlb=8192 noresume"

Inside that line, following part is duplicated:

root=/dev/mapper/dmroot console=hvc0 console=tty0 swiotlb=8192

/etc/default/grub.d/30-qubes.cfg then again adds:

console=hvc0 console=tty0

I don't know if duplicate options can cause problems but it makes boot parameters more difficult to read and modify.

Related: #5212
@adrelanos adrelanos added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Sep 23, 2019
@adrelanos adrelanos mentioned this issue Sep 23, 2019
Open
@andrewdavidwong andrewdavidwong changed the title unduplicate /boot/grub/grub.cfg kernel boot parameters /etc/default/grub Deduplicate /boot/grub/grub.cfg kernel boot parameters /etc/default/grub Sep 23, 2019
@andrewdavidwong andrewdavidwong added C: other P: minor Priority: minor. The lowest priority, below "default." T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Sep 23, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Sep 23, 2019
@adrelanos adrelanos mentioned this issue Jan 21, 2020
Merged
@andrewdavidwong andrewdavidwong modified the milestones: Release 4.0 updates, Release TBD Apr 7, 2023
@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Aug 13, 2023
@rapenne-s
Copy link

I don't think this issue is relevant anymore.

  • /etc/default/grub.d/30-qubes.cfg doesn't exist on R4.1
  • the parameter console is set to none on R4.1, and only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: other P: minor Priority: minor. The lowest priority, below "default." T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rapenne-s @adrelanos @andrewdavidwong