New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of small screen artifacts #54

Closed
marmarek opened this Issue Mar 8, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 6 Jul 2010 09:29 UTC
Some apps seem to display some very small graphical elements (windows) of the size of 1 or 2 pixels. They just don't look nicely, and so we should consider filtering out any windows of size smaller than, say 5 pixels?

An alternative solution to consider would be to propagate position information back to VMs, when the user moves VM's windows around Dom0 screen? This might also fix some other inaccuracies with positioning of some elements, like e.g. some OpenOffice menus, etc.

Migrated-From: https://wiki.qubes-os.org/ticket/54

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 27 Jul 2010 13:35 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 27 Jul 2010 13:35 UTC

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 5 Aug 2010 10:25 UTC
After syncing window position back to AppVM, most of the problems described in this ticket have vanished. However one still remains: it is The White Dot in the left top corner of the screen, which in fact is a 1x1 window that is sometimes created by one of the AppVM's Apps (usually it appears after the user works with firefox for some time). This is the info about the window taken from Dom0 via xwininfo )and then clicking mouse in the left top corner):

[qubes](joanna@vaio)$ xwininfo 

xwininfo: Please select the window about which you
          would like information by clicking the
          mouse in that window.

xwininfo: Window id: 0x260006f "Firefox"

  Absolute upper-left X:  0
  Absolute upper-left Y:  0
  Relative upper-left X:  0
  Relative upper-left Y:  0
  Width: 1
  Height: 1
  Depth: 24
  Visual: 0x21
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x20 (installed)
  Bit Gravity State: ForgetGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: yes
  Corners:  +0+0  -1599+0  -1599-899  +0-899
  -geometry 1x1+0+0

If we look at e.g. firefox windows, there are lots of windows of size 1x1, but they all usually have the "Map State" = "IsUnMapped", rather than IsViewable like in the case here.

What is interesting is that 1x1 window (The White Dot) is "sticky" in that it appears on all KDE workspaces. Possible reasons and solutions:

  1. It's a firefox bug? (I'm yet to track and see if the 1x1 window in the AppVM would have the IsViewable attribute, or is it overriden by the guid?) -- in that case we might add a check to guid to mkwindow() to no map window of sizes 1x1 and smaller.

  2. It's a guid bug -- it somehow overdies the Map State atribute and sets it to IsViewable, in which case this should be fixed in guid.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 5 Aug 2010 10:25 UTC
After syncing window position back to AppVM, most of the problems described in this ticket have vanished. However one still remains: it is The White Dot in the left top corner of the screen, which in fact is a 1x1 window that is sometimes created by one of the AppVM's Apps (usually it appears after the user works with firefox for some time). This is the info about the window taken from Dom0 via xwininfo )and then clicking mouse in the left top corner):

[qubes](joanna@vaio)$ xwininfo 

xwininfo: Please select the window about which you
          would like information by clicking the
          mouse in that window.

xwininfo: Window id: 0x260006f "Firefox"

  Absolute upper-left X:  0
  Absolute upper-left Y:  0
  Relative upper-left X:  0
  Relative upper-left Y:  0
  Width: 1
  Height: 1
  Depth: 24
  Visual: 0x21
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x20 (installed)
  Bit Gravity State: ForgetGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: yes
  Corners:  +0+0  -1599+0  -1599-899  +0-899
  -geometry 1x1+0+0

If we look at e.g. firefox windows, there are lots of windows of size 1x1, but they all usually have the "Map State" = "IsUnMapped", rather than IsViewable like in the case here.

What is interesting is that 1x1 window (The White Dot) is "sticky" in that it appears on all KDE workspaces. Possible reasons and solutions:

  1. It's a firefox bug? (I'm yet to track and see if the 1x1 window in the AppVM would have the IsViewable attribute, or is it overriden by the guid?) -- in that case we might add a check to guid to mkwindow() to no map window of sizes 1x1 and smaller.

  2. It's a guid bug -- it somehow overdies the Map State atribute and sets it to IsViewable, in which case this should be fixed in guid.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 5 Aug 2010 21:19 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 5 Aug 2010 21:19 UTC

@marmarek marmarek added P: minor and removed P: major labels Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 22 Sep 2010 23:16 UTC
Seems like gui-1.1.12 solves this problem :)

Member

marmarek commented Mar 8, 2015

Comment by joanna on 22 Sep 2010 23:16 UTC
Seems like gui-1.1.12 solves this problem :)

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment