New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Dom0's update button #540

Closed
marmarek opened this Issue Mar 8, 2015 · 18 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 24 Apr 2012 16:56 UTC
It currently does nothing... (even if it really does soemthing, it looks to the user as if it was doing nothing).

Migrated-From: https://wiki.qubes-os.org/ticket/540

@marmarek marmarek added this to the Release 1 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 25 Apr 2012 11:30 UTC
There is still a long delay between the time the button is pressed, and when the gpk-viewer window is presented to the user. Such delay suggests to the user that nothing happens, and then when the gpk-viewer window suddenly appears 30 secs later, the user already forgot that he or she initiated the update process, and is now only confused where this window came out.

In other words, we need some progress bar window in between.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 25 Apr 2012 11:30 UTC
There is still a long delay between the time the button is pressed, and when the gpk-viewer window is presented to the user. Such delay suggests to the user that nothing happens, and then when the gpk-viewer window suddenly appears 30 secs later, the user already forgot that he or she initiated the update process, and is now only confused where this window came out.

In other words, we need some progress bar window in between.

@marmarek marmarek reopened this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 25 Apr 2012 11:34 UTC
And, BTW, the check-for-udpdate in the manager for Dom0 doesn't go away after I checked the updates and got information that there were no updates available.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 25 Apr 2012 11:34 UTC
And, BTW, the check-for-udpdate in the manager for Dom0 doesn't go away after I checked the updates and got information that there were no updates available.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 25 Apr 2012 11:36 UTC
The same applies to other VMs -- if no updates are ready, the check-for-updates icon will persist...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 25 Apr 2012 11:36 UTC
The same applies to other VMs -- if no updates are ready, the check-for-updates icon will persist...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 25 Apr 2012 12:18 UTC
And, BTW, it still doesn't really work -- it always seems to show that there are no updates available, even though I just uploaded some updates, and qubes-dom0-updates picks them up correctly.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 25 Apr 2012 12:18 UTC
And, BTW, it still doesn't really work -- it always seems to show that there are no updates available, even though I just uploaded some updates, and qubes-dom0-updates picks them up correctly.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by aga on 26 Apr 2012 15:53 UTC
Progress bar while launching the updater:

http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=fb31ae041a1468a792abe8c384b5a002997a7b89

Member

marmarek commented Mar 8, 2015

Comment by aga on 26 Apr 2012 15:53 UTC
Progress bar while launching the updater:

http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=fb31ae041a1468a792abe8c384b5a002997a7b89

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 30 Apr 2012 12:23 UTC
Seems to be working fine now.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 30 Apr 2012 12:23 UTC
Seems to be working fine now.

@marmarek marmarek closed this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 26 May 2012 11:27 UTC
1-click updates for Dom0 still don't work -- the packages offered in gpk-viewer is only a SUBSET of all the available packages as displayed by qubes-dom0-update. Perhaps there is a missing yum clean call somewhere?

Member

marmarek commented Mar 8, 2015

Comment by joanna on 26 May 2012 11:27 UTC
1-click updates for Dom0 still don't work -- the packages offered in gpk-viewer is only a SUBSET of all the available packages as displayed by qubes-dom0-update. Perhaps there is a missing yum clean call somewhere?

@marmarek marmarek reopened this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 26 May 2012 11:28 UTC
core-dom0 2.0.23, manager 1.2.17

Member

marmarek commented Mar 8, 2015

Comment by joanna on 26 May 2012 11:28 UTC
core-dom0 2.0.23, manager 1.2.17

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 26 May 2012 12:08 UTC
gpk-update-viewer groups updates (so eg xen-* is listed as one update). Perhaps this is the source of difference? You can always expand updates tree.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 26 May 2012 12:08 UTC
gpk-update-viewer groups updates (so eg xen-* is listed as one update). Perhaps this is the source of difference? You can always expand updates tree.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 26 May 2012 12:58 UTC
No, I just uploaded new manager package, and gpk-viewer didn't display it -- it only displayed the kernel-qubes-vm 3.3.5 (that I removed from my system). So, it seems like it doesn't notice just-uploaded-very-recently packages...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 26 May 2012 12:58 UTC
No, I just uploaded new manager package, and gpk-viewer didn't display it -- it only displayed the kernel-qubes-vm 3.3.5 (that I removed from my system). So, it seems like it doesn't notice just-uploaded-very-recently packages...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 30 May 2012 11:44 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 30 May 2012 11:44 UTC

@marmarek marmarek added the C: core label Mar 8, 2015

@marmarek marmarek assigned marmarek and unassigned rootkovska Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 1 Jun 2012 18:38 UTC
Hopefully fixed by this commit:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=50a58c63311bd8da50e364dad814a303adaabf25

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 1 Jun 2012 18:38 UTC
Hopefully fixed by this commit:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=50a58c63311bd8da50e364dad814a303adaabf25

@marmarek marmarek closed this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 19 Jun 2012 14:19 UTC
As of core-dom0 2.0.27 and manager 1.2.20, this still doesn't work. Again, I just uploaded new rpms into the repos, then clicked on the Dom0 update button, and then got an empty gpk-viewer window telling me there were no updates available. So, I then typed qubes-dom0-update in the command line, and it immediately correctly found the updates. I suspect the update procedure via the manager doesn't do proper 'yum clean all'...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 19 Jun 2012 14:19 UTC
As of core-dom0 2.0.27 and manager 1.2.20, this still doesn't work. Again, I just uploaded new rpms into the repos, then clicked on the Dom0 update button, and then got an empty gpk-viewer window telling me there were no updates available. So, I then typed qubes-dom0-update in the command line, and it immediately correctly found the updates. I suspect the update procedure via the manager doesn't do proper 'yum clean all'...

@marmarek marmarek reopened this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 19 Jun 2012 21:00 UTC
Indeed there wasn't "--clean" option enabled.
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=1177a1d12482adadb8fbd3528811174c1a12a5ee

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 19 Jun 2012 21:00 UTC
Indeed there wasn't "--clean" option enabled.
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=1177a1d12482adadb8fbd3528811174c1a12a5ee

@marmarek marmarek closed this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 22 Jun 2012 18:22 UTC
As of qubes-manager 1.2.22 this still doesn't work -- again gpk-viewer shows no updates, while qubes-dom0-updates correctly shows some new updates.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 22 Jun 2012 18:22 UTC
As of qubes-manager 1.2.22 this still doesn't work -- again gpk-viewer shows no updates, while qubes-dom0-updates correctly shows some new updates.

@marmarek marmarek reopened this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 22 Jun 2012 21:52 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 22 Jun 2012 21:52 UTC

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 22 Jun 2012 22:39 UTC
Another try:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=ad7d6957b133b6a52e58e3ce2a5730d3bf46109b

Calling "yum clean all" as normal user doesn't return any error, but looks like also doesn't clean the cache...

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 22 Jun 2012 22:39 UTC
Another try:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=ad7d6957b133b6a52e58e3ce2a5730d3bf46109b

Calling "yum clean all" as normal user doesn't return any error, but looks like also doesn't clean the cache...

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment