Add "Copy clipboard to Qubes clipboard" option to manager

[marmarek]

Reported by joanna on 25 Apr 2012 11:54 UTC
... so that people can easily copy and paste e.g. logs from manager/dom0 to some VM where they have email client, and then send to qubes-devel :)

We could either provide a button in any of the logs viewer windows, or add a menu option in the manager's main menu and tray menu.

Migrated-From: https://wiki.qubes-os.org/ticket/543

[marmarek]

Comment by aga on 6 May 2012 21:44 UTC
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=b0d32f550d7e0e6ed37f2bd9e67582f75a2e1b90

and a silly fix:

http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=77e3d2feb06d2358cc22a0e03f62dfae756db865

[marmarek]

Comment by aga on 6 May 2012 21:44 UTC
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=b0d32f550d7e0e6ed37f2bd9e67582f75a2e1b90

and a silly fix:

http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=77e3d2feb06d2358cc22a0e03f62dfae756db865

[marmarek]

Comment by joanna on 9 May 2012 14:53 UTC
The copy-to-qubes-clibboard button should, of course, be placed in the respective windows where logs are displayed, and not in the main manager toolbar, where it can only confuse the user.

[marmarek]

Comment by joanna on 9 May 2012 14:53 UTC
The copy-to-qubes-clibboard button should, of course, be placed in the respective windows where logs are displayed, and not in the main manager toolbar, where it can only confuse the user.

[marmarek]

Comment by marmarek on 10 May 2012 00:40 UTC
Note that this button currently copy dom0 clipboard content to qubes clipboard. So IMHO there should be additional button "copy log to qubes clipboard" (placed in log viewer window of course). The current button still can be useful to copy output of some custom command (eg xl list or xl info).

[marmarek]

Comment by marmarek on 10 May 2012 00:40 UTC
Note that this button currently copy dom0 clipboard content to qubes clipboard. So IMHO there should be additional button "copy log to qubes clipboard" (placed in log viewer window of course). The current button still can be useful to copy output of some custom command (eg xl list or xl info).

[marmarek]

Comment by joanna on 10 May 2012 09:26 UTC

1. We need only one button that would do two things at once: copy the (displayed) log (from the log output) to Dom0 clipboard, and automatically copy this also to the Qubes clipboard.

2. Offering an option to copy arbitrary things from Dom0 to Qubes clipboard (and so to VMs) might not be the best security approach... I think we should assume that if somebody is going to hack around in the Dom0 terminal and wants to copy some arbitrary output from there (as opposed to the logs we expose in the manager), then this person should also go one step further in their terminal/qubes kung fu skills and also be able to copy this to the Qubes clipboard manually. And we can tell in the wiki how to do that.

[marmarek]

Comment by joanna on 10 May 2012 09:26 UTC

1. We need only one button that would do two things at once: copy the (displayed) log (from the log output) to Dom0 clipboard, and automatically copy this also to the Qubes clipboard.

2. Offering an option to copy arbitrary things from Dom0 to Qubes clipboard (and so to VMs) might not be the best security approach... I think we should assume that if somebody is going to hack around in the Dom0 terminal and wants to copy some arbitrary output from there (as opposed to the logs we expose in the manager), then this person should also go one step further in their terminal/qubes kung fu skills and also be able to copy this to the Qubes clipboard manually. And we can tell in the wiki how to do that.

[marmarek]

Comment by aga on 10 May 2012 11:31 UTC

1. We need only one button that would do two things at once: copy the (displayed) log (from the log output) to Dom0 clipboard, and automatically copy this also to the Qubes clipboard.

Why not copy the displayed text to the Qubes clipboard directly? (Thus ommitting copying it to Dom0 clipboard).

[marmarek]

Comment by aga on 10 May 2012 11:31 UTC

1. We need only one button that would do two things at once: copy the (displayed) log (from the log output) to Dom0 clipboard, and automatically copy this also to the Qubes clipboard.

Why not copy the displayed text to the Qubes clipboard directly? (Thus ommitting copying it to Dom0 clipboard).

[marmarek]

Comment by joanna on 10 May 2012 11:33 UTC
Yes, of course.

[marmarek]

Comment by joanna on 10 May 2012 11:33 UTC
Yes, of course.

[marmarek]

Comment by aga on 10 May 2012 11:50 UTC
So it's all done.

Log dialog:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=7890aac8e8050aebcf7b59de4080268df2e88419

Copy directly to qubes clipboard tweak:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=c78d382f264c4c3530ec1409813ab5797c0d4cf4

And no more copy-to-qubes-clipboard button in main window.
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=fb3ac12aa68436f56d6cff8ca1861970480f2e76

[marmarek]

Comment by aga on 10 May 2012 11:50 UTC
So it's all done.

Log dialog:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=7890aac8e8050aebcf7b59de4080268df2e88419

Copy directly to qubes clipboard tweak:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=c78d382f264c4c3530ec1409813ab5797c0d4cf4

And no more copy-to-qubes-clipboard button in main window.
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=fb3ac12aa68436f56d6cff8ca1861970480f2e76