New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui agent: don't log ANY non-warning/non-error messages #567

Closed
marmarek opened this Issue Mar 8, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 12 May 2012 12:01 UTC
... when run in normal mode (as opposed to "debug mode"). Currently the messages log is just overwhelmed by various debug info from gui agent. There is really no need for this, especially now, when we have a one-click debug mode.

Migrated-From: https://wiki.qubes-os.org/ticket/567

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 20 May 2012 00:07 UTC
Did you mean gui daemon (dom0 side)?
We haven't one-click debug mode for gui agent (VM side).

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 20 May 2012 00:07 UTC
Did you mean gui daemon (dom0 side)?
We haven't one-click debug mode for gui agent (VM side).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 21 May 2012 08:31 UTC
Ah indeed. Ok, so we shall add a debug switch for the gui agent as well. Really, trashing /var/log/messages with all this useless data isn't something that should happen in 1.0 release...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 21 May 2012 08:31 UTC
Ah indeed. Ok, so we shall add a debug switch for the gui agent as well. Really, trashing /var/log/messages with all this useless data isn't something that should happen in 1.0 release...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 21 May 2012 21:59 UTC
GUI agent already support log level. I've lowered default value:
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=934254a37157c88b336e7ffb7954d5632299ef8a

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 21 May 2012 21:59 UTC
GUI agent already support log level. I've lowered default value:
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=934254a37157c88b336e7ffb7954d5632299ef8a

@marmarek marmarek closed this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 22 May 2012 08:26 UTC
But the point is, that this debug log level should be possible to increase when the user ticks 'run in debug mode' in the manager...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 22 May 2012 08:26 UTC
But the point is, that this debug log level should be possible to increase when the user ticks 'run in debug mode' in the manager...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 22 May 2012 14:01 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 22 May 2012 14:01 UTC

@marmarek marmarek reopened this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 22 May 2012 14:52 UTC
Done. Debug mode status passed via xenstore and then prepared opts for gui-agent, based on its value.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 22 May 2012 14:52 UTC
Done. Debug mode status passed via xenstore and then prepared opts for gui-agent, based on its value.

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment