Correctly display maxmem for netvms

[marmarek]

Reported by joanna on 16 May 2012 13:23 UTC
For my netvms I see maxmem = 256M in the manager, while qvm-prefs returns 200M.

Also, I don't see a reason to block setting of the memory/maxmem for netvms, but ensure that maxmem=mem by default, see 525. However, because of #563, allow to also change maxmem if user wants. So, the desired behaviour should be:

1. when user changes a value in memory field and this vm has devices assigned, then automatically adjust maxmem to match whatever value is currently in memory,

2. but when user changes maxmem, then allow to change it, and do not change memory value. Just make sure, that maxmem >= memory.

Migrated-From: https://wiki.qubes-os.org/ticket/572

[marmarek]

Comment by marmarek on 18 May 2012 20:28 UTC
If dynamic memory management is disabled, maxmem setting is ignored and at VM startup maxmem set to vlue of memory. So if you want some other value of maxmem, first re-enable qmemman for this VM.

Anyway IMHO the only thing that should be ensured here is maxmem >= memory (by warning if it isn't), any other synchronization of maxmem and memory will only confuse the user.

[marmarek]

Comment by marmarek on 18 May 2012 20:28 UTC
If dynamic memory management is disabled, maxmem setting is ignored and at VM startup maxmem set to vlue of memory. So if you want some other value of maxmem, first re-enable qmemman for this VM.

Anyway IMHO the only thing that should be ensured here is maxmem >= memory (by warning if it isn't), any other synchronization of maxmem and memory will only confuse the user.

[marmarek]

Comment by aga on 19 May 2012 07:45 UTC
The wrong value was a result of silly min value setting in gui :)
Now setting the init_mem and maxmem are bind together, as Joanna has described it. However, it's all done regardless of whether dynamic mem management is enabled or not (What would happen on switching it back off? Maxmem would magically change? That's confusing...). My proposal would be just to gray it out when dynamic memory management is off (but not change the value!) or just leave it as it is, as it's ignored anyway.

The gui part:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=42828835cc75c0fc26e6ce9ece444c4602762293http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=42828835cc75c0fc26e6ce9ece444c4602762293

Ufortunately setting maxmem different than init_mem is not working for netvms on the core side (whatever the dynamic mem mgmt).

[marmarek]

Comment by aga on 19 May 2012 07:45 UTC
The wrong value was a result of silly min value setting in gui :)
Now setting the init_mem and maxmem are bind together, as Joanna has described it. However, it's all done regardless of whether dynamic mem management is enabled or not (What would happen on switching it back off? Maxmem would magically change? That's confusing...). My proposal would be just to gray it out when dynamic memory management is off (but not change the value!) or just leave it as it is, as it's ignored anyway.

The gui part:
http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=42828835cc75c0fc26e6ce9ece444c4602762293http://git.qubes-os.org/?p=aga/qubes-manager.git;a=commit;h=42828835cc75c0fc26e6ce9ece444c4602762293

Ufortunately setting maxmem different than init_mem is not working for netvms on the core side (whatever the dynamic mem mgmt).

[marmarek]

Comment by marmarek on 20 May 2012 00:11 UTC
http://git.qubes-os.org/?p=marmarek/core.git;a=commit;h=987a4901796faae7db792addd09fc317c7554c58

[marmarek]

Comment by marmarek on 20 May 2012 00:11 UTC
http://git.qubes-os.org/?p=marmarek/core.git;a=commit;h=987a4901796faae7db792addd09fc317c7554c58

[marmarek]

Comment by marmarek on 22 May 2012 10:39 UTC
Is something left to do in this task?

[marmarek]

Comment by marmarek on 22 May 2012 10:39 UTC
Is something left to do in this task?

[marmarek]

Comment by aga on 25 May 2012 10:46 UTC
It seems to work fine now.
Closing.

[marmarek]

Comment by aga on 25 May 2012 10:46 UTC
It seems to work fine now.
Closing.