Embedded YouTube player's fullscreen mode doesn't work in Chrome

[marmarek]

Reported by joanna on 9 Jul 2012 08:48 UTC
When one clicks on the 'fullscreen' button in the embedded youtube player, then only a very small window in the left top corner appears. It used to work fine until recently, so I suspect some latest GUI commit might have broke it.

Exemplary site where this can be observed:

http://www.auto-gyro.com/en/Gyroplanes/Video-Gallery/

(Start playing any of the movies there, and then click the 'fullscreen' button).

Migrated-From: https://wiki.qubes-os.org/ticket/618

[marmarek]

Modified by marmarek on 9 Jul 2012 17:20 UTC

[marmarek]

Modified by marmarek on 9 Jul 2012 17:20 UTC

[marmarek]

Comment by marmarek on 9 Jul 2012 18:32 UTC
On chromium 17 (didn't managed to download chrome 17) it works. Perhaps related to https://code.google.com/p/chromium/issues/detail?id=42467. The F11 don't work even in chromium 17.

I can add support for _NET_WM_STATE_FULLSCREEN to gui-agent, but the question is what it should do:
a) maximize window (as most apps currently fallback when no fullscreen advertised)
b) pass fullscreen request to dom0 window manager

The second option can give us real fullscreen (especially useful while watching movie). Maybe also will fix fullscreen on multi-monitor setup (eg. presentation mode in ooimpres in unusable - it maximize window to one display but show only half of slide).

This have of course some security implications, as will introduce possibility to hide colorful window decoration. This privilege can be settable on per-VM basis.

[marmarek]

Comment by marmarek on 9 Jul 2012 18:32 UTC
On chromium 17 (didn't managed to download chrome 17) it works. Perhaps related to https://code.google.com/p/chromium/issues/detail?id=42467. The F11 don't work even in chromium 17.

I can add support for _NET_WM_STATE_FULLSCREEN to gui-agent, but the question is what it should do:
a) maximize window (as most apps currently fallback when no fullscreen advertised)
b) pass fullscreen request to dom0 window manager

The second option can give us real fullscreen (especially useful while watching movie). Maybe also will fix fullscreen on multi-monitor setup (eg. presentation mode in ooimpres in unusable - it maximize window to one display but show only half of slide).

This have of course some security implications, as will introduce possibility to hide colorful window decoration. This privilege can be settable on per-VM basis.

[marmarek]

Comment by joanna on 9 Jul 2012 20:32 UTC
Perhaps we could do variant a) by default. When a user sets "fullscreen_allowed" for the VM via qvm-prefs, then we can do b) for this VM?

[marmarek]

Comment by joanna on 9 Jul 2012 20:32 UTC
Perhaps we could do variant a) by default. When a user sets "fullscreen_allowed" for the VM via qvm-prefs, then we can do b) for this VM?

[marmarek]

Comment by joanna on 9 Jul 2012 20:33 UTC
And maybe we can also have a global "fullscreen_allowed" controlled via qubes_prefs -- this makes sense for some users, like me, who constantly use something ala Expose for focus switching.

[marmarek]

Comment by joanna on 9 Jul 2012 20:33 UTC
And maybe we can also have a global "fullscreen_allowed" controlled via qubes_prefs -- this makes sense for some users, like me, who constantly use something ala Expose for focus switching.

[marmarek]

Comment by marmarek on 9 Jul 2012 20:39 UTC
As with all gui-daemon settings (/etc/qubes/guid.conf) it is possible to set both global defaults and per-VM overrides. But we currently have no support for its in qubes-manager...

[marmarek]

Comment by marmarek on 9 Jul 2012 20:39 UTC
As with all gui-daemon settings (/etc/qubes/guid.conf) it is possible to set both global defaults and per-VM overrides. But we currently have no support for its in qubes-manager...

[marmarek]

Comment by marmarek on 10 Jul 2012 14:08 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=f1c10b560f07d088b6f1d1292abd63d9957b6eef

The minor issue is that when no fullscreen allowed (->maximize is used), flashplayer place its controls outside of screen (only small part of it is visible) - looks like its internally uses screen size, not window size (which is smaller because of decoration)... But I think we can live with it.

[marmarek]

Comment by marmarek on 10 Jul 2012 14:08 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=f1c10b560f07d088b6f1d1292abd63d9957b6eef

The minor issue is that when no fullscreen allowed (->maximize is used), flashplayer place its controls outside of screen (only small part of it is visible) - looks like its internally uses screen size, not window size (which is smaller because of decoration)... But I think we can live with it.