New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize/obfuscate "set title for windows" messages in the guid logs #619

Closed
marmarek opened this Issue Mar 8, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 10 Jul 2012 17:50 UTC
This message leaks out private user's data, such as e.g. email subjects (titles for Thunderbirds message windows). e.g."

set title for window 0x340001c to Re: [Qubes] #617: NM icon disappears after resume from S3 sleep
Created 0x3400592(0x1042ac0) parent 0x0(0x131) ovr=1
Created 0x3400594(0x1042ba8) parent 0x0(0x131) ovr=1
Created 0x3400595(0x1042bae) parent 0x0(0x131) ovr=0

Migrated-From: https://wiki.qubes-os.org/ticket/619

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 10 Jul 2012 18:11 UTC
But this message is very useful when debugging oneself... Perhaps we want to obfuscate it in qubes-manager just before copying to shared clipboard?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 10 Jul 2012 18:11 UTC
But this message is very useful when debugging oneself... Perhaps we want to obfuscate it in qubes-manager just before copying to shared clipboard?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 10 Jul 2012 18:18 UTC
But the log already contains Windows IDs, and one can always use xwininfo to find out which window it is, including the titlebar.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 10 Jul 2012 18:18 UTC
But the log already contains Windows IDs, and one can always use xwininfo to find out which window it is, including the titlebar.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 10 Jul 2012 18:39 UTC
If window still exists...

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 10 Jul 2012 18:39 UTC
If window still exists...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 10 Jul 2012 20:41 UTC
If the window doesn't exist and the bug cannot be reproduced, then it's not a ticketable bug :)

Anyway, it's unacceptable to leak user's personal info into logs.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 10 Jul 2012 20:41 UTC
If the window doesn't exist and the bug cannot be reproduced, then it's not a ticketable bug :)

Anyway, it's unacceptable to leak user's personal info into logs.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 12 Jul 2012 11:39 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 12 Jul 2012 11:39 UTC

@marmarek marmarek self-assigned this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment