New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing only attachment of full device (sda, not sda1) in the manager menu #623

Closed
marmarek opened this Issue Mar 8, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 12 Jul 2012 14:43 UTC
If we attach a specific partition, e.g. sda1, then it won't appear in the VM's filemanager. So, perhaps a good tradeoff between usability and flexibility would be to only present a list of full devices in the manager menu, so to guarantee that the volume(s) appear automatically in the VM's manager. On the other hand, an advanced user willing to attach only a specific partition, could always use qvm-block command line to do that.

Migrated-From: https://wiki.qubes-os.org/ticket/623

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 12 Jul 2012 23:48 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=b650a3a27678a3be0bc8ca6fc79c72f7333516d1

Still allow to detach partition if attached manually.
Partition detection heuristic is quite dumb, but should work in most cases (detect sda2 naming scheme, but not d0p1 and not partitions >= 10).

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 12 Jul 2012 23:48 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=b650a3a27678a3be0bc8ca6fc79c72f7333516d1

Still allow to detach partition if attached manually.
Partition detection heuristic is quite dumb, but should work in most cases (detect sda2 naming scheme, but not d0p1 and not partitions >= 10).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 12 Jul 2012 23:55 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 12 Jul 2012 23:55 UTC

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment