New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the nasty sleep in NetVM::start() #637

Closed
marmarek opened this Issue Mar 8, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 20 Jul 2012 13:02 UTC

    # Cleanup stale VIFs
            vm.cleanup_vifs()

            # wait for frontend to forget about this device (UGLY HACK)
            time.sleep(0.2)

            try:
                vm.attach_network(wait=False)

This seems to possible break things only with netvm restart and vif reaatch.

Perhaps consider the following loop instead:


for vm in all_vms_connected_to_netvm:
  qvm-run $vm "rmmod netfront; modprobe netfront'

Migrated-From: https://wiki.qubes-os.org/ticket/637

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 21 Jul 2012 23:33 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 21 Jul 2012 23:33 UTC

@marmarek marmarek assigned marmarek and unassigned rootkovska Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment