New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Qubes RPC services #654

Closed

marmarek opened this Issue Mar 8, 2015 · 2 comments

Member

marmarek commented Mar 8, 2015

Reported by joanna on 10 Aug 2012 11:35 UTC

qubes.ReceiveUpdates
qubes.SyncAppmenus
qubes.FileCopy
qubes.NotifyUpdates

Can we really trust constructs like this:

line_rx.search(untrusted_line)

... on the other hand, if ptyhon's regexp was buggy, then LOTS of things would be breaking...

Migrated-From: https://wiki.qubes-os.org/ticket/654

marmarek added this to the Release 1 milestone Mar 8, 2015

marmarek added C: other P: major T: task labels Mar 8, 2015

Member

marmarek commented Mar 8, 2015

Comment by joanna on 10 Aug 2012 20:04 UTC
Plus, move all the Dom0 service files to special subdir in dom0/ dir.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 17 Aug 2012 12:02 UTC
Some more variables marked as untrusted:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=cc23d3cb3dffe8272a48fe4ca2d7929d211d6ca0
And services code moved to separate dir:
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=9b3a77bc1deb6ccfbf1cc1c1fe0231a66253382d

marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.