Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew automatic installer versioning #668
Comments
marmarek
added this to the Release 2 Beta 1 milestone
Mar 8, 2015
marmarek
added
enhancement
C: installer
P: major
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 9 Nov 2012 18:20 UTC
What is the difference? qubes-builder version is as independent of other core Qubes components as installer. Actually installer repo contains list of packages included in final ISO, so IMHO it even better place for release version (qubes-builder only fills installer repo, but it doesn't mean the packages will be included in ISO image). Qubes builder is even (theoretically) independent of used source branch...
Perhaps version should be extracted to separate file in installer repo or automatically filled based on qubes-release package version (the later is approach used by some Fedora stuff).
|
Comment by marmarek on 9 Nov 2012 18:20 UTC Perhaps version should be extracted to separate file in installer repo or automatically filled based on qubes-release package version (the later is approach used by some Fedora stuff). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 12 Nov 2012 10:01 UTC
The installer might contain the list of pkgs to install, but without specifying their versions.
Maybe, instead, we could have a special file called 'release', kept in the qubes-builder repo (but might be .gitignored if you don't like the idea of tracking the release in qubes-builder). This file would contain a string such as "R2-Beta1" and would be copied into the installer repo upon build, without requiring to change anything in the installer repo.
The only question is: how to use such external file in addition to the Anaconda .conf file we use currently:
http://git.qubes-os.org/?p=joanna/installer.git;a=blob;f=conf/qubes-install.conf;h=bfe20862f0971aecceae6477db09abe04f0bc136;hb=HEAD
?
|
Comment by joanna on 12 Nov 2012 10:01 UTC Maybe, instead, we could have a special file called 'release', kept in the qubes-builder repo (but might be .gitignored if you don't like the idea of tracking the release in qubes-builder). This file would contain a string such as "R2-Beta1" and would be copied into the installer repo upon build, without requiring to change anything in the installer repo. The only question is: how to use such external file in addition to the Anaconda .conf file we use currently: ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 12 Nov 2012 13:24 UTC
Embeding version into some config file isn't the problem, always we can use sed... Example here:
http://git.qubes-os.org/?p=marmarek/thunderbird-qubes.git;a=blob;f=Makefile;hb=HEAD#l60
Anyway I like this idea, additionally in absence of 'release' file it can assume version like "testbuild" or sth.
|
Comment by marmarek on 12 Nov 2012 13:24 UTC Anyway I like this idea, additionally in absence of 'release' file it can assume version like "testbuild" or sth. |
marmarek
self-assigned this
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 12 Nov 2012 13:31 UTC
Perhaps this can be option in builder.conf instead of separate file?
|
Comment by marmarek on 12 Nov 2012 13:31 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 12 Nov 2012 16:48 UTC
Ok, and we can use something like 'test-build' for builder.conf.default.
|
Comment by joanna on 12 Nov 2012 16:48 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 2 Nov 2012 14:38 UTC
The use of variable 'version' from installer/conf/qubes-installer.conf file is nto very fortunate, because this 'version' should reflect the version of Qubes as a whole (as burned into ISO) and not just the version of the installer repo. This variable should be set automatically, most preferably based on the most recent tag of the following from from the qubes-builder repo:
"R?-.*'
Migrated-From: https://wiki.qubes-os.org/ticket/668