New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When logging off from X session in Dom0, make sure that all guids disconnect first #720

Closed
marmarek opened this Issue Mar 8, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 25 Feb 2013 14:38 UTC
This is to avoid ugly tray icons becoming orphaned on such logout/system shutdown.

Migrated-From: https://wiki.qubes-os.org/ticket/720

@marmarek marmarek added this to the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 16 Nov 2013 12:19 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 16 Nov 2013 12:19 UTC

@marmarek marmarek added P: major and removed P: minor labels Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 18 Nov 2013 00:50 UTC
Is that really a major issue?
The problem is that VM tray icons windows aren't notified about "undock" event (when dock widget process is terminated). The proper solution would be to add such notification (so probably new GUI message). I'm strongly against GUI protocol modification for such minor thing.
Alternative some workaround would be adding some hook on tray manager termination (which is during logoff process) - probably via process watching tray manager selection, or some dummy icon. There is no clean KDE logoff hooks. And looking at the other KDE parts, there would be no guarantee about order of calling them.
I propose to close this as 'wontfix'.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 18 Nov 2013 00:50 UTC
Is that really a major issue?
The problem is that VM tray icons windows aren't notified about "undock" event (when dock widget process is terminated). The proper solution would be to add such notification (so probably new GUI message). I'm strongly against GUI protocol modification for such minor thing.
Alternative some workaround would be adding some hook on tray manager termination (which is during logoff process) - probably via process watching tray manager selection, or some dummy icon. There is no clean KDE logoff hooks. And looking at the other KDE parts, there would be no guarantee about order of calling them.
I propose to close this as 'wontfix'.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 18 Nov 2013 09:27 UTC
Lets move it to RC1 for now, where many other GUI-related polishing is also scheduled.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 18 Nov 2013 09:27 UTC
Lets move it to RC1 for now, where many other GUI-related polishing is also scheduled.

@marmarek marmarek removed this from the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 21 Mar 2014 12:53 UTC
It doesn't look to be easy to get logout notification, even for tray icons. Actual window manager process is terminated rather late in logout process, so simple hooks for WM-specific messages/properties doesn't solve the problem. Note that this behavior is the same on baremetal KDE, it isn't Qubes specific.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 21 Mar 2014 12:53 UTC
It doesn't look to be easy to get logout notification, even for tray icons. Actual window manager process is terminated rather late in logout process, so simple hooks for WM-specific messages/properties doesn't solve the problem. Note that this behavior is the same on baremetal KDE, it isn't Qubes specific.

@marmarek marmarek added the wontfix label Mar 8, 2015

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment