Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement "Move to VM" service #725
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by joanna on 18 Nov 2013 13:56 UTC |
marmarek
added this to the Release 2 Beta 3 milestone
Mar 8, 2015
marmarek
added
enhancement
C: core
P: minor
labels
Mar 8, 2015
marmarek
removed this from the Release 2 Beta 3 milestone
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 24 Mar 2014 03:00 UTC
The problem with shred is it doesn't support recursive operation (qvm-copy-to-vm supports directories, so qvm-move-to-vm also should).
But thanks to "discard" mount option it shouldn't be necessary - VM kernel tells dom0 that block freed by removed file aren't used anymore and respective part of private.img is reclaimed. Simple test:
[~](user@testvm)$ echo unique-string-eeV8mees1 > test.txt
[~](user@testvm)$ sync
[~](user@testvm)$ sudo grep 'unique-string-eeV8mees1' /dev/xvdb
Binary file /dev/xvdb matches
[~](user@testvm)$ rm -f test.txt
[~](user@testvm)$ sync
[~](user@testvm)$ sudo grep 'unique-string-eeV8mees1' /dev/xvdb
[~](user@testvm)$
Note that dom0 filesystem still could contain removed data, but in case of "Move to VM" service it isn't a problem - the data is already present in another VM private.img.
|
Comment by marmarek on 24 Mar 2014 03:00 UTC
Note that dom0 filesystem still could contain removed data, but in case of "Move to VM" service it isn't a problem - the data is already present in another VM private.img. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 24 Mar 2014 04:20 UTC
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fe6453978903d6a2a4fc1003b635c44733bbb3b3
|
Comment by marmarek on 24 Mar 2014 04:20 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 12 Mar 2013 14:57 UTC
A trivial extension of our qubes.FileCopy, only that the file should be removed (shred) from the source VM after the copy completes. Trivial, but handy...
Migrated-From: https://wiki.qubes-os.org/ticket/725