/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-grow-private do not call resize2fs properly #772

Closed
marmarek opened this Issue Mar 8, 2015 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 2 Beta 3
1 participant
@marmarek
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by marmarek on 28 Dec 2013 03:40 UTC
The private.img size is changed, but not the filesystem on it.

This can be related to this commit:
http://git.qubes-os.org/?p=marmarek/core-admin.git;a=commit;h=efeb284ab119451996667eec7b552a3967c9a3c5

Perhaps resize2fs needs to be added to VM startup scripts?

Migrated-From: https://wiki.qubes-os.org/ticket/772
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 15 Jan 2014 03:45 UTC
Actually resize2fs already was in VM startup scripts in packages released with R2 Beta3. So this problem shouldn't exists.

Related commit:
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fabc72701c168d63bad1a175523b127068fc6143

Closing for now, if someone is able to reproduce, then we'll reopen this issue.
Member

marmarek commented Mar 8, 2015

Comment by marmarek on 15 Jan 2014 03:45 UTC
Actually resize2fs already was in VM startup scripts in packages released with R2 Beta3. So this problem shouldn't exists.

Related commit:
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fabc72701c168d63bad1a175523b127068fc6143

Closing for now, if someone is able to reproduce, then we'll reopen this issue.

@marmarek marmarek added this to the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek marmarek added bug C: core P: major worksforme labels Mar 8, 2015

@marmarek marmarek closed this Mar 8, 2015

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue Apr 11, 2015

@marmarek
Fix resizing of /rw partition (private.img) 
Offline resize requires to run fsck -f first. Because we support only
growing that image, we can simply use online resize instead.

This finally fixes QubesOS/qubes-issues#772
65bc22f

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue Apr 16, 2015

@marmarek
Fix resizing of /rw partition (private.img) 
Offline resize requires to run fsck -f first. Because we support only
growing that image, we can simply use online resize instead.

This finally fixes QubesOS/qubes-issues#772

(cherry picked from commit 65bc22f)

Conflicts:
	vm-init.d/qubes-core
	vm-systemd/mount-home.sh
7f26835

@marmarek marmarek referenced this issue in QubesOS/qubes-doc Nov 20, 2015

Merged

resize2fs not required for qvm-grow-private #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment