New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-backup: '-z' applies compression after encryption #775

Closed
marmarek opened this Issue Mar 8, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by axon on 9 Jan 2014 10:55 UTC
Due to an openssl bug, '-z' applies compression after encryption when creating a backup (and vice versa when restoring from a backup). Since encrypted data cannot be compressed (and attempting to compress encrypted data typically results in a larger output), the backups created by qvm-backup are much larger than they should be.

See: https://groups.google.com/d/msg/qubes-users/XfyJHSCD4_U/Lw-jjiRNV2EJ

Migrated-From: https://wiki.qubes-os.org/ticket/775

@marmarek marmarek added this to the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by axon on 9 Jan 2014 10:56 UTC
Marek:

The final solution would adding gzip before openssl, but as a quick 'fix' there should be a warning/error about using compression and encryption (compression alone works fine).

Member

marmarek commented Mar 8, 2015

Comment by axon on 9 Jan 2014 10:56 UTC
Marek:

The final solution would adding gzip before openssl, but as a quick 'fix' there should be a warning/error about using compression and encryption (compression alone works fine).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 15 Jan 2014 04:56 UTC
Blocked encrypted and compressed backups:
http://git.qubes-os.org/?p=marmarek/core-admin.git;a=commit;h=26b32ca51ecd6edd4a4846c3fd549dd5da78a4e2

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 15 Jan 2014 04:56 UTC
Blocked encrypted and compressed backups:
http://git.qubes-os.org/?p=marmarek/core-admin.git;a=commit;h=26b32ca51ecd6edd4a4846c3fd549dd5da78a4e2

@marmarek marmarek removed this from the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 14 Mar 2014 12:43 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 14 Mar 2014 12:43 UTC

@marmarek marmarek added this to the Release 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 16 Apr 2014 16:44 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 16 Apr 2014 16:44 UTC

@marmarek marmarek added P: minor and removed P: major labels Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by woju on 30 Jun 2014 13:18 UTC

Member

marmarek commented Mar 8, 2015

Modified by woju on 30 Jun 2014 13:18 UTC

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 26 Sep 2014 02:00 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 26 Sep 2014 02:00 UTC

@marmarek marmarek self-assigned this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment