Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception rendering Salt states results in a zero exit code #7772

Closed
DemiMarie opened this issue Sep 17, 2022 · 3 comments
Closed

Exception rendering Salt states results in a zero exit code #7772

DemiMarie opened this issue Sep 17, 2022 · 3 comments
Labels
C: mgmt P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

If an exception occurs while rendering a Salt state, qubesctl returns a zero exit code.

Steps to reproduce

Create a Salt state that fails to render for some reason.

Expected behavior

Non-zero exit code from qubesctl

Actual behavior

Zero exit code
@DemiMarie DemiMarie added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Sep 17, 2022
@andrewdavidwong andrewdavidwong added C: mgmt needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 18, 2022
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Sep 18, 2022
@lkubb
Copy link

lkubb commented Jun 21, 2023

Pretty sure this is caused by salt-ssh exiting with 0 in that case as well, as mentioned in #7993 and saltstack/salt#64514. That issue will be fixed upstream in 3006.2.

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jun 21, 2023
@DemiMarie
Copy link
Author

Duplicate of #7993.

@DemiMarie DemiMarie closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2023
@DemiMarie DemiMarie added the R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one. label Jun 22, 2023
@andrewdavidwong
Copy link
Member

This appears to be a duplicate of an existing issue. If so, please comment on the appropriate existing issue instead. If anyone believes this is not really a duplicate, please leave a comment briefly explaining why. We'll be happy to take another look and, if appropriate, reopen this issue. Thank you.

@andrewdavidwong andrewdavidwong removed diagnosed Technical diagnosis has been performed (see issue comments). waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed. labels Jun 23, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: mgmt P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. R: duplicate Resolution: Another issue exists that is very similar to or subsumes this one. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lkubb @DemiMarie @andrewdavidwong